Uh oh!
There was an error while loading. Please reload this page.
lower log level for quota manipulation cases - #10034
Conversation
| $quota = $aQuota[0]; | ||
| } else { | ||
| $this->log->log('not suitable LDAP quota found for user ' . $this->uid . ': [' . $valueFromLDAP . ']', ILogger::WARN); | ||
| $this->log->log('no suitable LDAP quota found for user ' . $this->uid . ': [' . $aQuota[0] . ']', ILogger::DEBUG); |
There was a problem hiding this comment.
The $aQuota[0] could cause issues, because this else branch is also triggered when $aQuota determines to false or the count is 0 or lower.
There was a problem hiding this comment.
In that case, readAttribute would need to return an array, of size > 0, that does not use numeric indexes. This is not the case.
There was a problem hiding this comment.
Hu? I'm not following this.
readAttribute can return false.
In that case $aQuota would be false. The check fails. And we try to read $aQuota[0] which does 💥
Or am I missing something?
There was a problem hiding this comment.
doesn't log anything now when nothing was found, as was before.
and simplify the forest of ifs a little bit Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
1489a32 to
cc51a00CompareCodecov Report
@@ Coverage Diff @@## master #10034 +/- ##
=============================================
+ Coverage 31.72% 51.99% +20.27% - Complexity 26007 26011 +4
=============================================
Files 1661 1661 Lines 96132 96130 -2 Branches 1290 1290 =============================================
+ Hits 30494 49986 +19492 + Misses 65638 46144 -19494
|
that's all relevant for debug, and if nothing is set it is not even worth to write anything at all. I also decreased the nesting of the ifs.