Uh oh!
There was an error while loading. Please reload this page.
[stable13] lower log level for quota manipulation cases - #10076
Merged
Conversation
and simplify the forest of ifs a little bit Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzz
requested review from
GitHubUser4234, MorrisJobke, nickvergessen and rullzerJuly 2, 2018 10:09
MorrisJobke
approved these changes
Jul 2, 2018
nickvergessen
requested changes
Jul 2, 2018
| if($aQuota && (count($aQuota) > 0) && $this->verifyQuotaValue($aQuota[0])) { | ||
| $quota = $aQuota[0]; | ||
| } else if(is_array($aQuota) && isset($aQuota[0])) { | ||
| $this->log->log('no suitable LDAP quota found for user ' . $this->uid . ': [' . $aQuota[0] . ']', \OCP\Util::DEBUG); |
Member
There was a problem hiding this comment.
log->debug() instead of constant usage?
MemberAuthor
There was a problem hiding this comment.
Kept it as it was for backporting reasons
| } else { | ||
| $this->log->log('not suitable LDAP quota found for user ' . $this->uid . ': [' . $valueFromLDAP . ']', \OCP\Util::WARN); | ||
| } | ||
| $this->log->log('no suitable LDAP quota found for user ' . $this->uid . ': [' . $valueFromLDAP . ']', \OCP\Util::DEBUG); |
nickvergessen
approved these changes
Jul 2, 2018
nickvergessen
left a comment
Member
There was a problem hiding this comment.
Okay, its the backport already
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Codecov Report
@@ Coverage Diff @@## stable13 #10076 +/- ##
==============================================
- Coverage 51.43% 31.03% -20.4% - Complexity 25134 25138 +4
==============================================
Files 1613 1613 Lines 95634 95632 -2 Branches 1376 1376 ==============================================
- Hits 49185 29681 -19504 - Misses 46449 65951 +19502
|
blizzz
commented
Jul 2, 2018
MemberAuthor
failing test unrelated (ocassionally occuring files acceptance) → merging |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of #10034