Skip to content

Shorten resource table names to allow install on oracle again - #10213

Merged
MorrisJobke merged 2 commits into
masterfrom
bugfix/noid/shorten-resource-table-names-to-allow-install-on-oracle
Jul 12, 2018
Merged

Shorten resource table names to allow install on oracle again#10213
MorrisJobke merged 2 commits into
masterfrom
bugfix/noid/shorten-resource-table-names-to-allow-install-on-oracle

Conversation

@nickvergessen

@nickvergessennickvergessen commented Jul 12, 2018

Copy link
Copy Markdown
Member

Signed-off-by: Joas Schilling <coding@schilljs.com>

@georgehrkegeorgehrke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good 👍

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen

Copy link
Copy Markdown
MemberAuthor

Invitation table is also too long

@georgehrke

Copy link
Copy Markdown
Member

What's the exact limit that oracle enforces?

@MorrisJobke

Copy link
Copy Markdown
Member

What's the exact limit that oracle enforces?

32 AFAIK, but you need to mind the prefix ;)

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@MorrisJobke
MorrisJobke merged commit 09d5b61 into masterJul 12, 2018
@MorrisJobke
MorrisJobke deleted the bugfix/noid/shorten-resource-table-names-to-allow-install-on-oracle branch July 12, 2018 10:30
@nickvergessen

Copy link
Copy Markdown
MemberAuthor

i will write a checker for this

@nickvergessen

Copy link
Copy Markdown
MemberAuthor

https://travis-ci.org/nextcloud/notifications/builds/403051765 passing with this branch 👍

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@nickvergessen@georgehrke@MorrisJobke