Prevent too long identifier names

[nickvergessen]

Ref #10213

[MorrisJobke]

Fails for the calendar:

Index name "oc_calendar_resources_cache"."calendar_resources_cache_id_idx" is too long.

[nickvergessen]

Yeah wanted to fail it and now rebasing on #10213

[MorrisJobke]

Tested and works now 👍 Also code makes sense

[rullzer]

Can't this still do 💥 is people chose a to long prefix?

[georgehrke]

Can't this still do 💥 is people chose a to long prefix?

Well, that's the case for any table, not only this resource booking ones. If someone selects a 30-char long prefix it will just go 💥
We should properly document this though cc @MariusBluem

[MorrisJobke]

1) Test\DB\MigrationsTest::testExecuteStepWithSchemaChange
Invalid argument supplied for foreach()
/drone/src/github.com/nextcloud/server/lib/private/DB/MigrationService.php:464
/drone/src/github.com/nextcloud/server/lib/private/DB/MigrationService.php:451
/drone/src/github.com/nextcloud/server/tests/lib/DB/MigrationsTest.php:120

[nickvergessen]

Fixed and also added unit tests for all the checks

[nickvergessen]

Can't this still do boom is people chose a to long prefix?

Well if you use oracle you usually dont change such stuff anyway, because you know the limitations. The current code makes sure it works with a default prefix (3 chars). Anything else is not our business

[MorrisJobke]

Sequence name "oc_twofactor_backupcodes_id_seq" is too long.

[nickvergessen]

Right, default name on postgres is also not PRIMARY.
Let's see

[MorrisJobke]

Sequence name "oc_calendarsubscriptions_id_seq" is too long.

[nickvergessen]

Postgres is so annoying, anyway pushed a fix

[MorrisJobke]

Sequence name "oc_twofactor_backupcodes_id_seq" is too long. 

[nickvergessen]

I shall set it up locally for faster debugging this week.

[nickvergessen]

Fixed and tested locally with postgres, mysql and sqlite

[rullzer]

🐘