Fail the translation test when there are multiple single placeholders

[nickvergessen]

Temp solution to detect failing strings

[MorrisJobke]

this is more and administrative thing right? We should update all those strings. Isn't it better to wait for 15 or do we want to overhaul all the strings now? I guess this is for RTL languages, correct?

[nickvergessen]

Yeah, one more "broken" version, but well better then all in english for everyone

[MorrisJobke]

Yeah, one more "broken" version, but well better then all in english for everyone

We could also do it now ... still one month to go.

[MorrisJobke]

Most likely nothing for 14 -> moving to 15.

[MorrisJobke]

Rebased. Let's try to get this in.

[MorrisJobke]

I noticed following:

• this is checking the translation files - thus a failure will only be noticed once the code is in master, was synced to transifex, was translated there and then got synced back - that's too late. We maybe should use the translationtool.phar to extract the current strings and check this.
• "_%s group found_::_%s groups found_" is a false positive, because it is a plural string and not a string with two placeholders

[MorrisJobke]

Beside that all mentioned strings are already fixed.

[nickvergessen]

"%s group found::%s groups found" is a false positive, because it is a plural string and not a string with two placeholders

is a error in itself, if it is a plural it should use %n

[nickvergessen]

this is checking the translation files - thus a failure will only be noticed once the code is in master, was synced to transifex, was translated there and then got synced back - that's too late. We maybe should use the translationtool.phar to extract the current strings and check this.

Yeah, although it is still visible after the first pull from transifex because of en.
I just didn't find a better way.

[MorrisJobke]

Yeah, although it is still visible after the first pull from transifex because of en.
I just didn't find a better way.

I would let https://github.com/nextcloud/docker-ci/tree/master/translations/translationtool run in here and then check the generated .pot files for those strings. Then we can tackle it right away.

[ChristophWurst]

I would let https://github.com/nextcloud/docker-ci/tree/master/translations/translationtool run in here and then check the generated .pot files for those strings. Then we can tackle it right away.

What were the results? :D

[MorrisJobke]

What were the results? :D

It was never implemented 🙈

[stale]

This issue has been automatically marked as stale because it has not had recent activity and it seems to be missing some essential informations. It will be closed if no further activity occurs. Thank you for your contributions.

[rullzer]

Let me close this.
If somebody wants to pick this up feel free to reopen.