Uh oh!
There was an error while loading. Please reload this page.
14.0.0 Beta 1 - #10370
Merged
Merged
Conversation
MorrisJobke
commented
Jul 24, 2018
MemberAuthor
@skjnldsv@nickvergessen I added it to the "optional" section, but it might need to go to the must haves, right? |
nickvergessen
commented
Jul 24, 2018
Member
We didn't have "normal" guest avatars for so long, doesn't matter to not have them one more year. |
skjnldsv
commented
Jul 24, 2018
Member
Year?? 😱 |
nickvergessen
commented
Jul 24, 2018
Member
Version, sorry.... |
juliusknorr
commented
Jul 24, 2018
Member
Added:
|
MorrisJobke
commented
Jul 25, 2018
MemberAuthor
That is the failing acceptance test. |
MorrisJobkeforce-pushed
the
version/noid/14.0.0beta1
branch
2 times, most recently
from
July 25, 2018 15:45
7511e9c to
0022c10CompareSigned-off-by: Morris Jobke <hey@morrisjobke.de>
MorrisJobkeforce-pushed
the
version/noid/14.0.0beta1
branch
from
July 26, 2018 09:38
0022c10 to
6d9b8e4CompareMorrisJobke
requested review from
ChristophWurst, danxuliu, nickvergessen, rullzer and skjnldsvJuly 26, 2018 09:59
rullzer
approved these changes
Jul 26, 2018
nickvergessen
approved these changes
Jul 26, 2018
| // The human readable string | ||
| $OC_VersionString = '14.0.0 alpha'; | ||
| $OC_VersionString = '14.0.0 Beta 1'; |
There was a problem hiding this comment.
alpha is lowercase and beta upper?
MemberAuthor
There was a problem hiding this comment.
Was like that in the past:
This was referenced Sep 24, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Must haves
Nice to have
Add support for room shares #10255 Add support for room shares(moved to 15)Optional
Fail the translation test when there are multiple single placeholders #10219 Fail the translation test when there are multiple single placeholdersCheck proper case for user UID #9633 Check proper case for user UIDIntroduces avatars for guest users #10248 Introduces avatars for guest usersKnown bugs (and potential fixes)
Calendar ressource and room manager should not take implementations but class names #10212 Calendar ressource and room manager should not take implementations but class names (technical debt/public API)(does not block beta 1, but should be looked at during the bug fixing phase)Privacy: Avatar public available #5456 Privacy: Avatar public available(does not block beta 1, but should be looked at during the bug fixing phase)