Skip to content

Add Quick-Access to favorite folder in left sidepanel in files-app (Cleanup) - #10246

Closed
newhinton wants to merge 78 commits into
nextcloud:masterfrom
newhinton:14_VersionWithFavoritesQuickaccess_Cleanup
Closed

Add Quick-Access to favorite folder in left sidepanel in files-app (Cleanup)#10246
newhinton wants to merge 78 commits into
nextcloud:masterfrom
newhinton:14_VersionWithFavoritesQuickaccess_Cleanup

Conversation

@newhinton

@newhintonnewhinton commented Jul 15, 2018•
edited
Loading

Copy link
Copy Markdown
Contributor

fnuesseand others added 30 commits June 1, 2018 20:29
fnuesse
Added FavoritesQuickaccess-Sidebar
e86df3b
fnuesse
Added FavoritesQuickaccess-Sidebar
c484744
fnuesse
Added Files-FavoritesQuickaccess-Toggle
055243a
fnuesse
Fixed CSS for SpacerElement
b563db1
fnuesse
Removed Unnessessary Alerts and added Translations
32651d4
fnuesse
Tried fixing initial Quick-Access Checkboxstate
994a1c2
fnuesse
Tried fixing initial Quick-Access Checkboxstate
1fadbd3
Signed-off-by: fnuesse <fnuesse@techfak.uni-bielefeld.de>
fnuesse
Merge remote-tracking branch 'origin/master'
e347f77
fnuesse
Changed double-Quotes to single-Quotes
c1a8e81
fnuesse
Revert webdavurl which was changed by mistake
749fd5f
fnuesse
Revert quota-icon which was changed by mistake
cabd514
fnuesse
Changed the Folderhandling from custom-designed to nextcloud-Navigati…
81e651d
…onManager-handling
Signed-off-by: fnuesse <fnuesse@techfak.uni-bielefeld.de>
@newhinton
Moved CSS-Spacerclass to apps.scss for global usage
c0ef6fc
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
@newhinton
Renamed settings-caption in apps.scss to app-navigation-caption
ac98314
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
@newhinton
Removed old input-tag for showQuickAccess-state
6588bbe
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
@newhinton
Removed old spacer element in files.scss
dbc72cd
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
@newhinton
Changed style of favorites-sublist and disabled the ability to disabl…
675d0ac
…e files-quickaccess
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
@newhinton
Added toggleable QuickAccess
7e42f12
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
@newhinton
Deleted wrongly commited File
cf8a527
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
@newhinton
Added quickaccess-state persistence
1d0ec1b
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
@newhinton
Started implementing sorting-algorithm for proper alphabetical display
3a731e1
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
@newhinton
Finished Sorting of Quickaccess elements
c6f0749
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
@newhinton
Implemented persistence for reverse-list and sorting-strategy
245e1c0
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
@newhinton
Implemented initial sorting for reverse-list and sorting-strategy
69f52fa
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
@newhinton
Refactored Code
9a07345
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
@newhinton
Refactored Code
916fbd7
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
@newhinton
Refactored Code
deb2049
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
@newhinton
Fixed complete app-breakdown if no favorites are set
1f57988
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
@newhinton
Hid three-dot menu if no favorites are selected
7596d02
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
@newhinton
Added responsive folderadding
cc41b9f
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
@newhinton
Added custom order sorting option to quickaccess
24c2209
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
@newhinton
Added fallback for custom ordering
63ce668
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
@newhinton
Set Quickaccess-ordering to custom order
2cfae6f
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
@newhinton
Fix collapsible-Button when list was emptied (or got first element)
c7a4bed
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
@newhinton
Fixed Bad url-generation in javascript for new quickaccessitems
0ac7134
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
@newhinton
Fixed vertical scrolling in sortable-list which leads to "hidden" navbar
8b3dbba
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
@newhinton
Removed unnessessary console logs
7131707
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
@newhinton
Fixed Bounds in custom sorting
6059ec9
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
@newhinton
Reformatted code
c38af2c
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
@newhinton
Fixed horizontalscroll on sortable-list
b7fe0be
Fixed "stuck element" where you could not switch back to the original ordering in the sortable-list
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
@newhinton
Added drop-animation to sortable-list
c395b8c
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
@newhinton
Added icon-change on drag
8b9a6cb
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
@newhinton
Fixed Navbar-closing in app when favorites-list is toggled on mobile
80031f7
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
@newhinton
Refactored Code
daefeb5
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
@newhinton
Changed to alphabetical sorting
e79f749
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
@newhinton
Fixed deletion of folder with identical names
9809a7e
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
@newhinton
Removed ability to add files to the quickaccess
3721228
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
@newhinton
Fixed wrong path-generation when added from favorites-star
c2fb31d
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
@newhinton
Removed Element from navbar when favorite-star in detailview is toggl…
abec4ea
…ed off
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
@newhinton
Merge remote-tracking branch 'origin/master'
d6ea2c1
@newhinton
forkupdate from nextcloud/server
cd8bda3
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
@newhinton
removed sorting code from files app
d9d6285
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
@rullzer
rullzer requested a review from skjnldsvJuly 20, 2018 10:17
@rullzerrullzer added the 3. to review Waiting for reviews label Jul 20, 2018
@rullzer

rullzer commented Jul 20, 2018

Copy link
Copy Markdown
Member

@newhinton cool stuff thanks.

But this has a ton of conflicts. Also a ton of commits.

Could I ask you to rebase on current master.
Also you can create branches in the main server repo so other people can more easily work on your branch as well :)

THNX.

@newhinton

newhinton commented Jul 20, 2018

Copy link
Copy Markdown
ContributorAuthor

@rullzer Yes i have already seen that my forkupdate didn't work out as expected ;) I'll redo my latest PR's, tomorrow

@newhintonnewhinton mentioned this pull request Jul 20, 2018
Merged
@newhinton

newhinton commented Jul 20, 2018•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Old, since #10320 does the same and is better

@jospoortvliet

jospoortvliet commented Jul 23, 2018

Copy link
Copy Markdown
Member

@newhinton you coming to https://nextcloud.com/conf ?

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skjnldsvskjnldsvAwaiting requested review from skjnldsv

Assignees

No one assigned

Labels

3. to reviewWaiting for reviews

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@newhinton@rullzer@jospoortvliet