Uh oh!
There was an error while loading. Please reload this page.
Cleanup of leftover-sorting-code from quickaccess-feature #9714 #9720 - #10320
Merged
Conversation
newhinton
commented
Jul 20, 2018
ContributorAuthor
This was referenced Jul 20, 2018
MorrisJobke
approved these changes
Jul 24, 2018
MorrisJobke
left a comment
Member
There was a problem hiding this comment.
Tested and works still totally fine. 👍
skjnldsv
approved these changes
Jul 24, 2018
newhinton
commented
Jul 24, 2018
ContributorAuthor
@skjnldsv Can you give me a little hint here? How do i fix the missing sign-off's for the older commits? |
rullzer
commented
Jul 24, 2018
Member
@newhinton you'd need to do a |
rullzerforce-pushed
the
feature/10176/Quick-Access-Cleanup
branch
from
July 24, 2018 18:04
5bb14f3 to
fd61207CompareMorrisJobke
commented
Jul 24, 2018
Member
JSUnit tests fail :/ |
newhinton
commented
Jul 25, 2018
ContributorAuthor
I think i know why, but i'll need some time to fix it |
skjnldsv
commented
Jul 31, 2018
Member
@newhinton any news? :) |
newhinton
commented
Jul 31, 2018
ContributorAuthor
@skjnldsv I am currently writing exams, and also the heat is very problematic at the moment. I will return developing early next week, though! |
skjnldsv
commented
Jul 31, 2018
Member
Okay, i'll see if I can help before your return! :) |
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
skjnldsvforce-pushed
the
feature/10176/Quick-Access-Cleanup
branch
from
August 8, 2018 07:24
fd61207 to
7a78e0cCompare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #9714
See #9720
See #10176
See #10246