Skip to content

Login: Implements the "user disabled" message like the "wrong password" message - #10322

Merged
rullzer merged 3 commits into
nextcloud:masterfrom
weeman1337:feature-9978-improve-disabled-user-login-message
Jul 24, 2018
Merged

Login: Implements the "user disabled" message like the "wrong password" message#10322
rullzer merged 3 commits into
nextcloud:masterfrom
weeman1337:feature-9978-improve-disabled-user-login-message

Conversation

@weeman1337

@weeman1337weeman1337 commented Jul 21, 2018

Copy link
Copy Markdown
Member

It now looks like the password message:
image

closes#9978

Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
@weeman1337weeman1337 added design Design, UI, UX, etc. 3. to review Waiting for reviews papercut Annoying recurring UX issue with possibly simple fix. labels Jul 23, 2018
@skjnldsv
skjnldsv requested a review from danxuliuJuly 23, 2018 20:35

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works and the code looks good 👍

@MorrisJobke

Copy link
Copy Markdown
Member

@weeman1337 Thanks for this nice PR. The code looks nice. If you are up for some other tasks you could have a look at the "good first issues" ones https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

beside that feel free to join the IRC channel #nextcloud-dev for developer related chat. ;)

@MorrisJobkeMorrisJobke added this to the Nextcloud 14 milestone Jul 24, 2018
@MorrisJobkeMorrisJobke mentioned this pull request Jul 24, 2018
21 tasks
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
@danxuliu
danxuliuforce-pushed the feature-9978-improve-disabled-user-login-message branch from 29c1388 to 801bf81CompareJuly 24, 2018 15:31
@danxuliu

Copy link
Copy Markdown
Member

I amended the commit with the acceptance tests to just fix some indentation and to set the same password for the disabled user as for the other user (consistency nitpicking ;-) ). Otherwise really nice @weeman1337, thanks a lot!

@skjnldsvskjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 24, 2018
@weeman1337

weeman1337 commented Jul 24, 2018

Copy link
Copy Markdown
MemberAuthor

fix some indentation

@danxuliu does that mean the 80 chars limit from the dev docs "is adjustable"? :)

@danxuliu

Copy link
Copy Markdown
Member

@weeman1337

does that mean the 80 chars limit from the dev docs "is adjustable"? :)

Oh, please, you add unit tests, acceptance tests... and even read and try to abide by the dev docs? I am going to cry with joy ;-)

Anyway, as Hector Barbossa would tell you :-P , the 80 char limit is more what you would call a guideline than an actual rule. Of course better to stick to it as much as possible, but it is one of those things that can be not respected in favour of better legibility or consistency.

@rullzer
rullzer merged commit 71028fd into nextcloud:masterJul 24, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishdesignDesign, UI, UX, etc.papercutAnnoying recurring UX issue with possibly simple fix.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Login as deactivated user shows an error

5 participants

@weeman1337@MorrisJobke@danxuliu@skjnldsv@rullzer