Uh oh!
There was an error while loading. Please reload this page.
Improve performance when dealing with large numbers of shares - #10724
Merged
Conversation
Signed-off-by: Robin Appelman <robin@icewind.nl>
this changes the complexity from the number of mounts to the depth of the path Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991force-pushed
the
large-share-count-performance
branch
from
August 16, 2018 17:30
5ba91c4 to
f1b6a69CompareSigned-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991force-pushed
the
large-share-count-performance
branch
2 times, most recently
from
August 16, 2018 19:09
6286680 to
20e1042CompareSigned-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
…directory Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
this saves searching for shares on non-public link dav requests Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991force-pushed
the
large-share-count-performance
branch
from
August 16, 2018 19:28
20e1042 to
67f3d6fCompareicewind1991
requested review from
MorrisJobke, nickvergessen, rullzer and schiessleAugust 16, 2018 19:37
rullzer
commented
Aug 17, 2018
Member
wow. That are some impressive numbers. |
rullzer
approved these changes
Aug 24, 2018
rullzer
left a comment
Member
There was a problem hiding this comment.
Code looks good.
Lets get it in
rullzer
commented
Aug 24, 2018
Member
The changes look save to me. I did some small smoke testing and it didn't blow up. Also for sharing we have quite a lot of tests |
MorrisJobke
approved these changes
Aug 24, 2018
Merged
This was referenced Aug 27, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes a number of loops.
Comparisons with 2k shares as the receiver:
Listing root folder with the shares in a subfolder: https://blackfire.io/profiles/compare/e0ff76bc-8d96-4842-9b34-37acaf446294/graph
Listing the folder containing all the shares: https://blackfire.io/profiles/compare/f6054929-f61e-43bb-8241-55550ecd5204/graph