Skip to content

[13] Improve performance when dealing with large numbers of shares - #10884

Merged
MorrisJobke merged 11 commits into
stable13from
large-share-count-performance-13
Sep 27, 2018
Merged

[13] Improve performance when dealing with large numbers of shares#10884
MorrisJobke merged 11 commits into
stable13from
large-share-count-performance-13

Conversation

@icewind1991

@icewind1991icewind1991 commented Aug 27, 2018•
edited
Loading

Copy link
Copy Markdown
Member

Backport of #10724

@icewind1991
remove double loop for detecting changed mounts
67ae310
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
use more efficient method to find mountpoint for path
bb09255
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
cache OC\Files\Mount\Manager::findIn results
65c8fd3
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
cache OC\Files\Mount\Manager::findIn results
f199e7e
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
more efficient unique share target generation
f2152ec
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
more efficient way to detect added and removed mounts
c897e2a
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
re-use view instances for shared storages
a396c37
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
don't check if target dir exists when using the default share target …
237e4b7
…directory
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
only determine is sharing is disabled for a user once
110650f
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
tokens can't be valid local user names
e3b9e9e
this saves searching for shares on non-public link dav requests
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
cache parent exists status during share setup
6dae2b9
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991icewind1991 added the 3. to review Waiting for reviews label Aug 27, 2018
@icewind1991icewind1991 added this to the Nextcloud 13.0.7 milestone Aug 27, 2018
@icewind1991icewind1991 changed the title [13] A dav plugin to allow pagination of multipart responses[13] Improve performance when dealing with large numbers of sharesAug 27, 2018
rullzer
rullzer approved these changes Sep 5, 2018
View reviewed changes

@rullzerrullzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@MorrisJobke
MorrisJobke merged commit 065ec74 into stable13Sep 27, 2018
@MorrisJobke
MorrisJobke deleted the large-share-count-performance-13 branch September 27, 2018 15:20
This was referenced Oct 3, 2018
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzerrullzerrullzer approved these changes
@MorrisJobkeMorrisJobkeMorrisJobke approved these changes

Assignees

No one assigned

Labels

3. to reviewWaiting for reviews

Projects

None yet

Milestone

Nextcloud 13.0.7

Development

Successfully merging this pull request may close these issues.

3 participants

@icewind1991@rullzer@MorrisJobke