Uh oh!
There was an error while loading. Please reload this page.
fix linebreak on public share page - #10850
Conversation
MorrisJobke
commented
Aug 25, 2018
That's the one @tobiasKaminsky also experienced. @jancborchardt@skjnldsv Is this how you want it? |
tobiasKaminsky
commented
Aug 27, 2018
@MorrisJobke no, my problem is that on the border there is a link to the current page, and a little bit below there is then the link to /signup. |
tobiasKaminsky
commented
Aug 27, 2018
After testing this PR with Julius, I can confirm that this is working now as expected. 👍 |
juliusknorr
commented
Aug 27, 2018
@violoncelloCH Can you add the missing sign-off message to your commit? Otherwise this looks good 👍 |
violoncelloCH
commented
Aug 27, 2018
@juliushaertl do I just have to add the line to the commit or does the commit have to be signed with my pgp key? Because this one was created with over github web and therefore is signed with githubs key. |
juliusknorr
commented
Aug 27, 2018
@violoncelloCH The line needs to be added to your commit message. |
violoncelloCH
commented
Aug 27, 2018
@juliushaertl sorry, I'm a beginner with git... I try to find a way to do this |
managed to do a rebase, create a new signed commit locally and pushed it but only to a new branch |
in text "Get your own free account"
fixes#10849