Uh oh!
There was an error while loading. Please reload this page.
fix linebreak on public share page - #10878
Conversation
juliusknorr
commented
Aug 27, 2018
I'd like to get @skjnldsv to have a look as well, maybe there was a reason for the +/-13px |
MorrisJobke
commented
Aug 28, 2018
@jancborchardt you and @skjnldsv discussed about this quite heavily ... could you have a look at this please. |
skjnldsv
commented
Aug 28, 2018
@juliushaertl@MorrisJobke this is what I talked to you about. Basically this is to allow links to have a bigger clickable area, but css can go 💥 with those kind of 'hacks' |
MorrisJobke
commented
Aug 28, 2018
I know, but as this was a longer offline discussion I would like to have it written down here as well and to get to a common conclusion and not just merge the stuff without have a common view. |
rullzer
commented
Oct 2, 2018
@jancborchardt did you fix this in a different PR yesterday? |
violoncelloCH
commented
Oct 2, 2018
@rullzer I think @juliushaertl at least startet with a fix in #10912 |
MorrisJobke
commented
Oct 2, 2018
You are referring to #11499 |
MorrisJobke
commented
Oct 2, 2018
And yes - this is fixed by #11499. |
jancborchardt
commented
Oct 2, 2018
And also for the record – the padding is intended, for better clickability. And the negative margin is needed to make the text flow ok again left and right. Yes it can use improvement, but let’s not remove it. :) |
same changes as in #10850 but hopefully correctly signed off this time
fixes#10849
Signed-off-by: Jonas Sulzer jonas@violoncello.ch