allow to create multiple link shares via share api by schiessle · Pull Request #11844 · nextcloud/server

schiessle · 2018-10-15T10:45:37Z

Allow to create multiple share links (API level)
Get multiple share links (API level)
allow to give share links unique names (API level)
allow to change unique name of a share (API level)
Allow to create multiple share links (web ui)
Show multiple share links (web ui)
allow to give share links unique names (web ui)
allow to change unique name of a share (web ui)

for ux discussion, etc see #11169
Fix#10434
Closes#11537 : not possible, we cannot wait for the request of a new share to be done as the .done or success hooks generate a new scope and a clipboard triggered by a click needs to be in a direct call of a function triggered by an event :(
Fix#11169

schiessle · 2018-10-17T08:56:21Z

cc @AndyScherzinger @tobiasKaminsky @marinofaggiana @camilasan @rullzer With Nextcloud 15 we will support multiple share links. This PR already implements everything you need to start implementing it on the client side. Just in case you are looking for something to do 😉

Creating links works the same as before. There is just the additional parameter "label" you can use to create/update link shares so that the user can give the share link names to remember which link was used for what.

marinofaggiana · 2018-10-18T10:41:02Z

ToDo added :-)

jancborchardt · 2018-10-18T12:25:54Z

I’d suggest to split this up to prevent it from becoming too big of a pull request:

API stuff:

Allow to create multiple share links (API level)
Get multiple share links (API level)
allow to give share links unique names (API level)
allow to change unique name of a share (API level)

Basic interface stuff:

Allow to create multiple share links (web ui)
Show multiple share links (web ui)

Future interface stuff that is optional:

allow to give share links unique names (web ui)
allow to change unique name of a share (web ui)

Especially since you already mentioned the possible conflicts with #11537 (which is quite short so shouldn’t really conflict a lot.)

jancborchardt · 2018-10-30T14:28:14Z

Just had a short call with @skjnldsv, and this is the spec now:

The default share list has one entry in it called 🔗 Share link as usual. On the right there’s a ➕ icon.
- We have no checkbox anymore. A link either exists or not.
Clicking the whole row (not only the ➕) converts the entry into an active link
- Automatically copies it to clipboard, with a tooltip as feedback "Link copied".
- By default with read-only permissions (or edit? what do you think?)
- It also replaces the ➕ icon with 📋 Copy link and 🞄🞄🞄 buttons.
- Do we want to automatically open the 🞄🞄🞄 menu here too? (Maybe at least for the first link so it kind of shows people the options?)
Clicking the 🞄🞄🞄 button reveals the menu we know with the adjustment options.
- Additionally it will have an entry called ➕ Add another link (feel free to suggest better/more succinct wording)
- Tapping that entry will create another entry below it, basically same as step 2 above, automatically activating it and copying etc.

That’s that for now. Did I forget anything @skjnldsv?
In the future we can also have renaming of links, but for now it will just be "Share link", "Share link 2", "Share link 3" etc. Or ideally "Share link (read-only)" and "Share link 2 (read-only)" and "Share link (editable)" and "Share link (password-protected)".

Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>

skjnldsv · 2018-10-31T09:57:07Z

Should be finished today!
@jancborchardt @nextcloud/designers Can we try to find another saying for "Share link" I'm always finding this confusing as it looks like an action and not a statement :)

Can you start a review now?
That would increase my response time to fixes to day for the feature freeze :)

Basically the only thing left is the label handling! How should we do that?

Add an edit button?
In the popovermenu?

jancborchardt · 2018-10-31T11:17:30Z

Just beginning to test this! :) First feedback:

The ➕ icon is not keyboard-accessible, no highlight on focus
Ideally the whole row should be clickable, not just the ➕
Not sure it’s screenreader-accessible right now with the "title" on the icon. But it would be when the whole row is the action.

jancborchardt · 2018-10-31T11:24:50Z

Made the background of the share link primary color instead of bland grey. This is in line with the change in the Talk app at nextcloud/spreed#1274

skjnldsv · 2018-10-31T15:21:09Z

Made the background of the share link primary color instead of bland grey. This is in line with the change in the Talk app at nextcloud/spreed#1274

I was afraid it would be too much, but it is spot on!! 👍

danxuliu

Fixed

Not so fast; I have some complaints ;-)

skjnldsv · 2018-11-01T16:19:51Z

@danxuliu be quick!
I want to get this in today! And don't use this as an excuse to merge your pr before mine :p

Fixed :D

danxuliu

Fixed :D

Almost :-P I will send a final fix.

skjnldsv · 2018-11-01T19:10:02Z

Failure unrelated: sh: 1: kill: No such processhttps://drone.nextcloud.com/nextcloud/server/12248/283

skjnldsv · 2018-11-01T19:10:39Z

Almost :-P I will send a final fix.

Ahaha! Okay :)
Thanks a lot for your help @danxuliu 🤗

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>

Although now it is possible to create several link shares the acceptance tests currently handles only the first link share; this first link share is now created by clicking an "Add new share" button instead of a checkbox. Besides that, the "Copy link" button has been moved from the menu to the row, next to the menu trigger. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

danxuliu

Rejoice; finally, the nitpicker is reasonably satisfied 👍

I hope Drone is too... :-P

MorrisJobke · 2018-11-01T21:01:36Z

🎉 I will merge once drone has done it's job 🎉

lopezio · 2019-05-03T17:34:02Z

Future interface stuff that is optional:
allow to give share links unique names (web ui)
allow to change unique name of a share (web ui)

@schiessle @jancborchardt any progress on these points..? I think they're fundamental to make the multiple linking functionality usable.. with some kind of distinction between the shared links it would be possible to explicitely delete or re-share links based on a target public / individual..

Best Regards!

schiessle added enhancement 2. developing Work in progress feature: sharing labels Oct 15, 2018

schiessle added this to the Nextcloud 15 milestone Oct 15, 2018

schiessle mentioned this pull request Oct 18, 2018
Automatically open and copy the menu on public link share activation #11537
Closed

schiessle force-pushed the multiple-link-shares branch from fb8bae2 to 18e720dCompare October 18, 2018 12:37

skjnldsv assigned skjnldsv and schiessle Oct 29, 2018

skjnldsv force-pushed the multiple-link-shares branch from 18e720d to c26d581Compare October 29, 2018 07:18

skjnldsv reviewed Oct 29, 2018
View reviewed changes

Comment threadcore/Migrations/Version13000Date20170718121200.php Outdated

jancborchardt mentioned this pull request Oct 30, 2018
Sharing UI accessibility #11661
Closed

allow to create multiple link shares via share api
d0411b2
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>

skjnldsv force-pushed the multiple-link-shares branch from b7bdd4b to 9503528Compare October 31, 2018 07:27

skjnldsv added the high label Oct 31, 2018

This was referenced Oct 31, 2018
Share link not visible because of ad blockers #10434
Closed
Do not set indeterminate state for file shares #12163
Merged

skjnldsv added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Oct 31, 2018

skjnldsv requested review from MorrisJobke, danxuliu, juliusknorr and rullzer October 31, 2018 17:00

MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 1, 2018

danxuliu requested changes Nov 1, 2018
View reviewed changes

danxuliu previously requested changes Nov 1, 2018
View reviewed changes

skjnldsv force-pushed the multiple-link-shares branch from 957b150 to 719e977Compare November 1, 2018 18:19

danxuliu requested changes Nov 1, 2018
View reviewed changes

skjnldsvand others added 10 commits November 1, 2018 21:29

Migrate link shares to array
1bd6d39
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

Copy link outside menu
106ed07
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

Fix note display
206d612
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

Fix enforce date
260290e
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

Fix password enforcement
a7ea3d2
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

Use primary color for share link icon background instead of bland grey
7bfb322
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>

Fix wording, sort 'Add another link' to bottom so it does not confuse
9dea41f
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>

Password policy fix and menu open on first share
0a70544
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

Fixed jsunit
876d6ec
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

danxuliu force-pushed the multiple-link-shares branch from 719e977 to 876d6ecCompare November 1, 2018 20:38

danxuliu approved these changes Nov 1, 2018
View reviewed changes

MorrisJobke mentioned this pull request Nov 1, 2018
Add support for sending the password for a link share by Nextcloud Talk #11875
Merged

skjnldsv force-pushed the multiple-link-shares branch from 876d6ec to ef7d2a0Compare November 1, 2018 21:12

danxuliu force-pushed the multiple-link-shares branch from ef7d2a0 to 876d6ecCompare November 1, 2018 21:25

MorrisJobke merged commit f28691c into masterNov 1, 2018

MorrisJobke deleted the multiple-link-shares branch November 1, 2018 21:36

lopezio mentioned this pull request May 10, 2019
Allow editing of public share(s) link label(s) in WebUI #15500
Closed

Uh oh!

Uh oh!

Conversation

schiessle commented Oct 15, 2018• edited by skjnldsv Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

schiessle commented Oct 17, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

marinofaggiana commented Oct 18, 2018

Uh oh!

jancborchardt commented Oct 18, 2018

Uh oh!

Uh oh!

jancborchardt commented Oct 30, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

skjnldsv commented Oct 31, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jancborchardt commented Oct 31, 2018

Uh oh!

jancborchardt commented Oct 31, 2018

Uh oh!

skjnldsv commented Oct 31, 2018

Uh oh!

danxuliu left a comment

Choose a reason for hiding this comment

Uh oh!

skjnldsv commented Nov 1, 2018

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

danxuliu left a comment

Choose a reason for hiding this comment

Uh oh!

skjnldsv commented Nov 1, 2018

Uh oh!

skjnldsv commented Nov 1, 2018

Uh oh!

danxuliu left a comment

Choose a reason for hiding this comment

Uh oh!

MorrisJobke commented Nov 1, 2018

Uh oh!

lopezio commented May 3, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

schiessle commented Oct 15, 2018•
edited by skjnldsv
Loading

schiessle commented Oct 17, 2018•
edited
Loading

jancborchardt commented Oct 30, 2018•
edited
Loading

skjnldsv commented Oct 31, 2018•
edited
Loading