Uh oh!
There was an error while loading. Please reload this page.
Do not set indeterminate state for file shares - #12163
Merged
Merged
Conversation
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
requested review from
ChristophWurst, MorrisJobke, danxuliu and skjnldsvOctober 31, 2018 10:28
skjnldsv
commented
Oct 31, 2018
Member
Stop editing the sharing!! 😢 |
skjnldsv
approved these changes
Oct 31, 2018
juliusknorr
commented
Oct 31, 2018
MemberAuthor
@skjnldsv I can't, it's broken. 🙈 But we can wait until your changes are merged 😉 this one is probably a bit easier to rebase. |
skjnldsv
commented
Oct 31, 2018
Member
@juliushaertl you can also merge on my pr if you want :) |
juliusknorr
commented
Oct 31, 2018
MemberAuthor
Let's keep it separate so we can properly track the changes. This one needs a backport, since it is broken on 14 as well. |
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
commented
Oct 31, 2018
MemberAuthor
I've added some tests as well. |
MorrisJobke
commented
Nov 1, 2018
Member
CI failures are unrelated and are fixed on master already |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Files just have one edit permission checkbox, so having an indeterminate state there doesn't make sense and actually broke updating the edit permission on file shares. Found this while checking the failing tests in #12105.
Fixes#11730
@nextcloud/javascript