Uh oh!
There was an error while loading. Please reload this page.
Indicate users default quota (issue: #11393) - #12081
Closed
MasterOfDeath wants to merge 1 commit into
Closed
Conversation
violoncelloCH
commented
Oct 27, 2018
Member
PR #12087 targets the same issue |
juliusknorr
commented
Oct 30, 2018
Member
Thank you very much for your pull request @MasterOfDeath and welcome as a Nextcloud contributor. As @violoncelloCH mentioned there is another PR #12087, that uses existing data in the frontend to indicate the default quota. I'd vote to go this approach instead of extending the backend code with another parameter. |
juliusknorr
commented
Oct 30, 2018
Member
cc @skjnldsv for feedback |
Indicate users default quota Signed-off-by: Rinat Gumirov <rinat.gumirov@mail.ru>
MasterOfDeathforce-pushed
the
Indicate-users-default-quota
branch
from
October 30, 2018 19:34
f884295 to
3e6ad7aComparekesselb
commented
Oct 31, 2018
Contributor
Ref #12159 |
juliusknorr
commented
Nov 2, 2018
Member
Let's go with #12087, since that seems to be the cleanest approach code wise. Anyway thanks for the work @MasterOfDeath, I hope to see more contributions from you soon 😉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes#11393