Skip to content

Indicate default quota - #12087

Closed
AasthaGupta wants to merge 1 commit into
masterfrom
Aastha/11393
Closed

Indicate default quota#12087
AasthaGupta wants to merge 1 commit into
masterfrom
Aastha/11393

Conversation

@AasthaGupta

@AasthaGuptaAasthaGupta commented Oct 27, 2018

Copy link
Copy Markdown
Member

screenshot from 2018-10-28 03-08-22

Fixes#11393

@violoncelloCHvioloncelloCH mentioned this pull request Oct 27, 2018
Closed
@violoncelloCH

violoncelloCH commented Oct 27, 2018

Copy link
Copy Markdown
Member

PR #12081 targets the same issue

@rullzerrullzer added the 3. to review Waiting for reviews label Oct 29, 2018
@ArtificialOwl

ArtificialOwl commented Oct 30, 2018•
edited
Loading

Copy link
Copy Markdown
Member

Thanks for your contribution, please sign your work when committing!

https://github.com/nextcloud/appstore/blob/master/CONTRIBUTING.md#sign-your-work

@AasthaGupta
Indicate default quota
6f628de
Fixes#11393
Signed-off-by: Aastha Gupta <aastha.gupta4104@gmail.com>
@AasthaGupta

AasthaGupta commented Oct 30, 2018

Copy link
Copy Markdown
MemberAuthor

Thanks @daita .Signed.

kesselb
kesselb reviewed Oct 30, 2018
View reviewed changes
Comment thread.htaccess
</IfModule>
#### DO NOT CHANGE ANYTHING ABOVE THIS LINE ####

ErrorDocument 403 /server/

@kesselbkesselbOct 30, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you revert this?

@kesselb

kesselb commented Oct 30, 2018•
edited
Loading

Copy link
Copy Markdown
Contributor

Regenerating core/vendor/core.js
The merged vendor file is not up to date
Please run: php build/mergejs.php
And commit the result

CI failure

juliusknorr
juliusknorr reviewed Oct 30, 2018
View reviewed changes
Comment threadcore/js/mimetypelist.js
"text/x-shellscript": "text/code",
"web": "text/code",
"application/internet-shortcut": "link"
"web": "text/code"

@juliusknorrjuliusknorrOct 30, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this change also doesn't belong here 😉

@juliusknorr

juliusknorr commented Oct 30, 2018

Copy link
Copy Markdown
Member
  • There seems to be a bug if the default quota is set to unlimited. In that case the UI always shows 1GB for users with default quota.

@juliusknorrjuliusknorr added 2. developing Work in progress papercut Annoying recurring UX issue with possibly simple fix. feature: settings and removed 3. to review Waiting for reviews labels Oct 30, 2018
@kesselb

kesselb commented Oct 31, 2018

Copy link
Copy Markdown
Contributor

Ref #12159

@juliusknorrjuliusknorr mentioned this pull request Nov 2, 2018
Closed
@MorrisJobkeMorrisJobke added this to the Nextcloud 15 milestone Nov 2, 2018
@skjnldsv

skjnldsv commented Nov 6, 2018

Copy link
Copy Markdown
Member

If not fixed today, I'm afraid this will have to go to 16 :(

@MorrisJobke

MorrisJobke commented Nov 6, 2018

Copy link
Copy Markdown
Member

@skjnldsv you could also cherry pick Update the branch right here to help out and get it into shape.

This was referenced Nov 6, 2018
Merged
Merged
@ChristophWurstChristophWurst mentioned this pull request Jan 30, 2019
Closed
@ChristophWurst

ChristophWurst commented Jan 30, 2019

Copy link
Copy Markdown
Member

-> integrated the review feedback in a cherry-picked version: #13909

@ChristophWurst
ChristophWurst deleted the Aastha/11393 branch January 30, 2019 09:09
@ChristophWurstChristophWurst removed this from the Nextcloud 16 milestone Jan 30, 2019
@ChristophWurstChristophWurst removed the 2. developing Work in progress label Jan 30, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juliusknorrjuliusknorrjuliusknorr left review comments
@kesselbkesselbkesselb left review comments
@rullzerrullzerAwaiting requested review from rullzer
@skjnldsvskjnldsvAwaiting requested review from skjnldsv

Assignees

No one assigned

Labels

feature: settingspapercutAnnoying recurring UX issue with possibly simple fix.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@AasthaGupta@violoncelloCH@ArtificialOwl@kesselb@juliusknorr@skjnldsv@MorrisJobke@ChristophWurst@rullzer