Uh oh!
There was an error while loading. Please reload this page.
Use the proper server for the apptoken flow login - #12177
Merged
Conversation
rullzer
requested review from
ChristophWurst, MorrisJobke, blizzz, juliusknorr and schiessleOctober 31, 2018 22:10
This was referenced Oct 31, 2018
Member
no tests? they need to be touched anyhow, CI is unhappy. |
rullzerforce-pushed
the
fix/apptoken_login_flow_proper_host
branch
from
November 1, 2018 10:09
6234023 to
bd9b452CompareMorrisJobke
previously requested changes
Nov 1, 2018
| #### DO NOT CHANGE ANYTHING ABOVE THIS LINE #### | ||
| ErrorDocument 403 / | ||
| ErrorDocument 404 / |
If a user can't authenticate normally (because they have 2FA that is not available on their devices for example). The redirect that is generated should be of the proper format. This means 1. Include the protocol 2. Include the possible subfolder Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzerforce-pushed
the
fix/apptoken_login_flow_proper_host
branch
from
November 1, 2018 10:45
bd9b452 to
92582a3CompareChristophWurst
approved these changes
Nov 2, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a user can't authenticate normally (because they have 2FA that is not
available on their devices for example). The redirect that is generated
should be of the proper format.
This means
Discovered while debugging nextcloud/desktop#596