Skip to content

[stable13] Fix loginflow with apptoken enter on iOS - #13374

Merged
rullzer merged 1 commit into
stable13from
backport/13363/stable13
Jan 5, 2019
Merged

[stable13] Fix loginflow with apptoken enter on iOS#13374
rullzer merged 1 commit into
stable13from
backport/13363/stable13

Conversation

@MorrisJobke

Copy link
Copy Markdown
Member

Backport of #13363

@MorrisJobkeMorrisJobke added bug 3. to review Waiting for reviews labels Jan 4, 2019
@MorrisJobkeMorrisJobke added this to the Nextcloud 13.0.9 milestone Jan 4, 2019
@MorrisJobke
MorrisJobkeforce-pushed the backport/13363/stable13 branch from 3cebf47 to c38d838CompareJanuary 4, 2019 22:03
@MorrisJobke

Copy link
Copy Markdown
MemberAuthor

There was the method getServerPath added in 15.0.0 and back ported to stable14 in #12177 - I added it to this branch as well. After that the login works just fine. 👍

This was referenced Jan 4, 2019
return new Http\RedirectResponse($redirectUri);
}

private function getServerPath(): string {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

13 also support php5. 6

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting

It seems iOS doesn't like us to change the location. So now we submit it
to the server that geneartes the redirect.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer
rullzerforce-pushed the backport/13363/stable13 branch from c38d838 to 2757a42CompareJanuary 5, 2019 14:55

@rullzerrullzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed it

@rullzer
rullzer merged commit de761e2 into stable13Jan 5, 2019
@rullzer
rullzer deleted the backport/13363/stable13 branch January 5, 2019 15:41
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@MorrisJobke@rullzer@blizzz