Skip to content

Improve tests - #1227

Merged
nickvergessen merged 2 commits into
masterfrom
improve-tests
Sep 1, 2016
Merged

Improve tests#1227
nickvergessen merged 2 commits into
masterfrom
improve-tests

Conversation

@MorrisJobke

@MorrisJobkeMorrisJobke commented Sep 1, 2016

Copy link
Copy Markdown
Member
  • removes unneeded method that is windows only
  • properly loads APCu to run these tests

cc @rullzer@nickvergessen

@MorrisJobkeMorrisJobke added the 3. to review Waiting for reviews label Sep 1, 2016
@MorrisJobkeMorrisJobke added this to the Nextcloud 11.0 milestone Sep 1, 2016
@MorrisJobke

MorrisJobke commented Sep 1, 2016

Copy link
Copy Markdown
MemberAuthor

Before:

PHP 5.6: There were 88 skipped tests
PHP 7.0: There were 87 skipped tests

@MorrisJobke

MorrisJobke commented Sep 1, 2016

Copy link
Copy Markdown
MemberAuthor

After:

PHP 5.6: There were 68 skipped tests
PHP 7.0: Failing ... I will split out the PHP 7 part in a separate PR.

@rullzer

rullzer commented Sep 1, 2016

Copy link
Copy Markdown
Member

Shouldn't we do proper test splits for the different cache backends?

@MorrisJobke

MorrisJobke commented Sep 1, 2016

Copy link
Copy Markdown
MemberAuthor

Shouldn't we do proper test splits for the different cache backends?

That too

@MorrisJobkeMorrisJobke mentioned this pull request Sep 1, 2016
Merged
@MorrisJobke

MorrisJobke commented Sep 1, 2016

Copy link
Copy Markdown
MemberAuthor

@LukasReschke mind to review this easy one?

@rullzer

rullzer commented Sep 1, 2016

Copy link
Copy Markdown
Member

👍

@MorrisJobke

MorrisJobke commented Sep 1, 2016

Copy link
Copy Markdown
MemberAuthor

@nickvergessen mind to review this one as well?

@nickvergessen

nickvergessen commented Sep 1, 2016

Copy link
Copy Markdown
Member

👍

@nickvergessen
nickvergessen merged commit d3f8235 into masterSep 1, 2016
@nickvergessen
nickvergessen deleted the improve-tests branch September 1, 2016 12:02
@MorrisJobkeMorrisJobke mentioned this pull request Nov 8, 2016
Merged
@MorrisJobke

MorrisJobke commented Nov 8, 2016

Copy link
Copy Markdown
MemberAuthor

Stable10: #2048

@yesiamdollaryesiamdollar mentioned this pull request Oct 12, 2024
Open
@04033500350403350035 mentioned this pull request Oct 16, 2024
Open
@dwoodiwissdwoodiwiss mentioned this pull request Oct 18, 2024
Open
@kaocher82kaocher82 mentioned this pull request Oct 18, 2024
Open
@gisforgirardgisforgirard mentioned this pull request Oct 19, 2024
Open
@Jessi1983Jessi1983 mentioned this pull request Oct 22, 2024
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

3. to reviewWaiting for reviews

Projects

None yet

Milestone

Nextcloud 11.0

Development

Successfully merging this pull request may close these issues.

3 participants

@MorrisJobke@rullzer@nickvergessen