Skip to content

[stable10] Update containers to latest version - #2048

Merged
MorrisJobke merged 3 commits into
stable10from
stable10-update-containers
Nov 8, 2016
Merged

[stable10] Update containers to latest version#2048
MorrisJobke merged 3 commits into
stable10from
stable10-update-containers

Conversation

@MorrisJobke

Copy link
Copy Markdown
Member

@MorrisJobkeMorrisJobke added the 3. to review Waiting for reviews label Nov 8, 2016
@MorrisJobkeMorrisJobke added this to the Nextcloud 10.0.2 milestone Nov 8, 2016
@mention-bot

Copy link
Copy Markdown

@MorrisJobke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @rullzer and @LukasReschke to be potential reviewers.

@MorrisJobke

Copy link
Copy Markdown
MemberAuthor
There was 1 failure:
1) Test\Memcache\APCuTest::testDec
Failed asserting that -1 is false.
/drone/src/github.com/nextcloud/server/tests/lib/Memcache/Cache.php:90

This looks like this PHP7.0 breaking change - let me check the PR for master for this.

@MorrisJobke

Copy link
Copy Markdown
MemberAuthor

To test on the current PHP 7 we should maybe backport #1227 and #1230 (otherwise APCu on PHP 7 is broken for stable10 🙈 ) - cc @karlitschek

@karlitschek

Copy link
Copy Markdown
Member

please backport 👍

This was referenced Nov 8, 2016
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Fix an issue with APCus inc and dec methods on PHP 7
see krakjoe/apcu#183 (comment) for details
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke
MorrisJobkeforce-pushed the stable10-update-containers branch from e82bd16 to 3f45794CompareNovember 8, 2016 11:29
@nickvergessen

Copy link
Copy Markdown
Member

👍

@MorrisJobke
MorrisJobke merged commit 9071fd5 into stable10Nov 8, 2016
@MorrisJobke
MorrisJobke deleted the stable10-update-containers branch November 8, 2016 13:37
@rockihack

Copy link
Copy Markdown

@MorrisJobkeCall to undefined method OC\\LargeFileHelper::getFileSizeViaCOM() since 3f45794.

You forgot to remove the function call here:

$fileSize = $this->getFileSizeViaCOM($filename);

MorrisJobke added a commit that referenced this pull request Nov 24, 2016
* fixes#2048 (comment)
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@MorrisJobke@mention-bot@karlitschek@nickvergessen@rockihack