Uh oh!
There was an error while loading. Please reload this page.
[stable10] Update containers to latest version - #2048
Merged
Conversation
mention-bot
commented
Nov 8, 2016
@MorrisJobke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @rullzer and @LukasReschke to be potential reviewers. |
MorrisJobke
commented
Nov 8, 2016
MemberAuthor
This looks like this PHP7.0 breaking change - let me check the PR for master for this. |
MorrisJobke
commented
Nov 8, 2016
MemberAuthor
To test on the current PHP 7 we should maybe backport #1227 and #1230 (otherwise APCu on PHP 7 is broken for stable10 🙈 ) - cc @karlitschek |
karlitschek
commented
Nov 8, 2016
Member
please backport 👍 |
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Fix an issue with APCus inc and dec methods on PHP 7 see krakjoe/apcu#183 (comment) for details Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
MorrisJobkeforce-pushed
the
stable10-update-containers
branch
from
November 8, 2016 11:29
e82bd16 to
3f45794Comparenickvergessen
commented
Nov 8, 2016
Member
👍 |
rockihack
commented
Nov 24, 2016
@MorrisJobke You forgot to remove the function call here: server/lib/private/LargeFileHelper.php Line 101 in f7a505d |
MorrisJobke added a commit
that referenced
this pull request
Nov 24, 2016
* fixes#2048 (comment) Signed-off-by: Morris Jobke <hey@morrisjobke.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @rullzer@LukasReschke
see also #2047