Fix calendar emails to be outlook compatible

[hdijkema]

Signed-off-by: hdijkema hans@dykema.nl

[jospoortvliet]

ref #12885 - nicely done with lots of comments, hartelijk dank @hdijkema ! Now let's see if @georgehrke can review...

[georgehrke]

supersedes #12921

[georgehrke]

cc @nickvergessen regarding the changes to Mailer

[georgehrke]

Can you please cover your changes with Unit tests? Thx! :)

[hdijkema]

Can you please cover your changes with Unit tests? Thx! :)

Where can I find the current unit tests?

[kesselb]

Sorry to interrupt. Is it possible that this patch is related to the timezone issue you are describing? sabre-io/vobject#412

[hdijkema]

Sorry to interrupt. Is it possible that this patch is related to the timezone issue you are describing? sabre-io/vobject#412

This fix in Sabre solves the DTSTART / DTEND TZID problem for Outlook 2016 and 2010. I hope it will be part of nextcloud soon. So we can leave out the timezone fix in IMipPlugin.php.

[kesselb]

Thank you! Looks good so far.

[kesselb]

The method here works different than addParthttps://github.com/nextcloud/3rdparty/blob/da8e24b48079cec2f9c8be950f7b996bce172190/swiftmailer/swiftmailer/lib/classes/Swift/Message.php#L72 (from swiftmailer). I would prefer another name than because addPart from swiftmailer add a part with the current encoder while these method always uses 8bit encoder. I would add getEncoder and setEncoder and set the encoding from IMipPlugin but lets ask @nickvergessen first.

[georgehrke]

@hdijkema Can you please comment and/or adapt to @kesselb 's comment? :)

#12946 (comment)

[hdijkema]

@hdijkema Can you please comment and/or adapt to @kesselb 's comment? :)

#12946 (comment)

No problem at all to change the name of addPart(). Be my guest.

[hdijkema]

There seems to be no record for the failure:

https://drone.nextcloud.com/nextcloud/server/14710

results in a 404. See below?

[kesselb]

Builds logs are deleted after some time to save space. Rebase the branch to trigger CI again.

[nickvergessen]

Suggested change

	$eightbit_encoder = new \Swift_Mime_ContentEncoder_PlainContentEncoder("8bit");
	$eightbitEncoder = new \Swift_Mime_ContentEncoder_PlainContentEncoder('8bit');

[nickvergessen]

Suggested change

	$this->swiftMessage->setEncoder($eightbit_encoder);
	$this->swiftMessage->setEncoder($eightbitEncoder);

[nickvergessen]

Suggested change

	publicfunction addPart($data, $content_type = null, $charset = null): IMessage {
	publicfunction addPart($data, $contentType = null, $charset = null): IMessage {

[nickvergessen]

Suggested change

	$this->swiftMessage->addPart($data, $content_type, $charset);
	$this->swiftMessage->addPart($data, $contentType, $charset);

[ChristophWurst]

@hdijkema 🏓 :)

[hdijkema]

@hdijkema 🏓 :)

?

[ChristophWurst]

There are pending changes from the review and

Rebase the branch to trigger CI again.

Could you look into that? Cheers

[hdijkema]

There are pending changes from the review and

Rebase the branch to trigger CI again.

Could you look into that? Cheers

There are pending changes from the review and

Rebase the branch to trigger CI again.

Could you look into that? Cheers

I'm sorry, I'm lost here. Don't know what to do. I moved back to owncloud after problems with nextcloud and have not been back to nextcloud again the last year. I prepared this patch about 2 years ago, because back then I wanted nextcloud to send proper invites for calendar items. Got it working; next thing I find was this mergerequest stuck on integration checks that I don't understand.

It also was stuck on waiting for a new release of the underlying calendar library (forgot it's name). Maybe you can just review what I've done and put the right changes in the NextCloud tree yourself?

[ChristophWurst]

Ok, then I'll close it and anyone who would like to continue this work can just restore the branch and do the rest.