Skip to content

Fix calendar emails to be outlook compatible - recreation of #12946 - #34324

Closed
merlinwoff wants to merge 0 commit into
nextcloud:masterfrom
merlinwoff:master
Closed

Fix calendar emails to be outlook compatible - recreation of #12946#34324
merlinwoff wants to merge 0 commit into
nextcloud:masterfrom
merlinwoff:master

Conversation

@merlinwoff

@merlinwoffmerlinwoff commented Sep 29, 2022•
edited by tcitworld
Loading

Copy link
Copy Markdown

Recreated the abandoned pull request #12946 in order to include review changes. Let's see if that works now ;)

Closes#12885

ChristophWurst
ChristophWurst reviewed Sep 29, 2022
View reviewed changes
Comment threadlib/public/Mail/IMessage.php Outdated
github-advanced-security[bot]
github-advanced-securityAI found potential problems Sep 29, 2022
View reviewed changes
Comment threadlib/private/Mail/Message.php Fixed
tcitworld
tcitworld reviewed Sep 29, 2022
View reviewed changes

@tcitworldtcitworld left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicks

Comment threadlib/private/Mail/Message.php Outdated
Comment threadlib/public/Mail/IMessage.php Outdated
Comment threadlib/private/Mail/Message.php Outdated
Comment threadlib/private/Mail/Message.php Outdated
miaulalala
miaulalala approved these changes Sep 29, 2022
View reviewed changes

@miaulalalamiaulalala left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (except for Christoph's comment), the RFC for iMIP explicitly allows this.

Thanks for taking care of this.

github-advanced-security[bot]
github-advanced-securityAI found potential problems Sep 29, 2022
View reviewed changes
Comment threadlib/private/Mail/Message.php Fixed
@tcitworldtcitworld added this to the Nextcloud 26 milestone Sep 29, 2022
@ChristophWurstChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 12, 2023
@ChristophWurst

ChristophWurst commented Jan 12, 2023

Copy link
Copy Markdown
Member

The rebase and push broke the PR. Sorry about that.

@ChristophWurstChristophWurst mentioned this pull request Jan 12, 2023
Merged
4 tasks
@ChristophWurst

ChristophWurst commented Jan 12, 2023

Copy link
Copy Markdown
Member

The rebase and push broke the PR. Sorry about that.

#36118

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurstChristophWurstChristophWurst left review comments
@tcitworldtcitworldtcitworld approved these changes
@miaulalalamiaulalalamiaulalala approved these changes

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finishenhancementfeature: caldavRelated to CalDAV internalsfeature: davintegration

Projects

None yet

Milestone

Nextcloud 26

Development

Successfully merging this pull request may close these issues.

Calendar Invites - Outlook integration

5 participants

@merlinwoff@ChristophWurst@tcitworld@miaulalala@github-advanced-security