Use npm for js depdencies, bundle with webpack by ChristophWurst · Pull Request #13156 · nextcloud/server

ChristophWurst · 2018-12-19T11:05:31Z

Fixes#13071

Checklist:

(Based on https://github.com/nextcloud/server/blob/ad9ece4e4839297e50d34bb50481a78407f6b835/bower.json)

rullzer · 2018-12-19T12:00:19Z

zxcvbn

I guess we'd want to leave that one separate. As it is huge.

ChristophWurst · 2018-12-19T12:13:07Z

I guess we'd want to leave that one separate. As it is huge.

Hugely unmaintained? https://github.com/dropbox/zxcvbn/commits/master

ChristophWurst · 2018-12-19T12:14:15Z

Found https://www.npmjs.com/package/asdfgh. That might be a nice replacement one day.

rullzer · 2018-12-19T12:15:18Z

👍 would probably make most sense if strengthify uses that directly in a package etc.

ChristophWurst · 2018-12-20T17:07:30Z

Impressive!

$ du core/vendor/core.js 988 core/vendor/core.js
$ du core/js/dist/main.js
972 core/js/dist/main.js

… and that even includes more scripts and styles 🚀

ChristophWurst · 2018-12-20T17:10:01Z

* zxcvbn

This one lib needs special treatment. It's not used directly but loaded dynamically (as @rullzer commted above due to its size). Hence I would propose to leave it vendored, open an enhancement ticket and fix this later on. This PR is already huge and I don't want to start touching any scripts.

ChristophWurst · 2018-12-20T17:10:40Z

cc @nextcloud/javascript for review/testing :)

rullzer · 2018-12-20T18:44:14Z

🚀!

So I guess at certain places we can remove additional scripts loaded etc.
But we can followup on that.

So far I did not notice anything doing 💥 yet!

skjnldsv · 2018-12-21T09:21:05Z

@@ -0,0 +1,16 @@
+{


(unrelevant) I think there is something called babel global config, could be nice using it ?

haven't heard of it but sounds nice ;)

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

…effects Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Signed-off-by: Julius Härtl <jus@bitgrid.net>

juliusknorr · 2019-01-09T14:14:32Z

Rebased and pushed a fix for the select2 result list. Really nice @ChristophWurst 👍

tcitworld · 2019-01-09T14:54:05Z

+ "modules": false,
+ "targets": {
+ "browsers": [
+ "last 2 versions",


This just reminded me https://jamie.build/last-2-versions

Yeah … we can improve that later 😉

MorrisJobke

nice 👍 Tested and works 👍

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

ChristophWurst · 2019-01-09T15:59:57Z

So https://drone.nextcloud.com/nextcloud/server/14388/248 still fails with

Fixed. This was apparently an issue with 3.4.5 (the latest 3.4 version from npm). Updating to 3.4.8 (the version installed via bower) via git fixed the issue 🚀

MorrisJobke · 2019-01-09T16:05:27Z

Fixed. This was apparently an issue with 3.4.5 (the latest 3.4 version from npm). Updating to 3.4.8 (the version installed via bower) via git fixed the issue 🚀

Let's see if https://drone.nextcloud.com/nextcloud/server/14389/248 is working.

MorrisJobke · 2019-01-09T16:08:58Z

Let's see if https://drone.nextcloud.com/nextcloud/server/14389/248 is working.

Yes it does \o/

coliff · 2019-03-05T17:07:33Z

Hi @ChristophWurst - I saw above you included "bootstrap": "3.3.7", - this version has a couple of XSS vulnerabilities and is not recommended to use. Can you please update that to v3.4.1?
REF:
https://blog.getbootstrap.com/2019/02/13/bootstrap-4-3-1-and-3-4-1/
https://snyk.io/vuln/npm:bootstrap

ChristophWurst · 2019-03-05T17:15:41Z

Yep, we are aware of it and working on integrating the new version: #14352

We are on 3.4.1 meanwhile:

server/package.json

Line 30 in a4b34ab

"bootstrap": "^3.4.1",

ChristophWurst added enhancement 2. developing Work in progress technical debt 🧱 🤔🚀 labels Dec 19, 2018

ChristophWurst self-assigned this Dec 19, 2018

tcitworld reviewed Dec 19, 2018
View reviewed changes

Comment threadpackage.json

ChristophWurst force-pushed the enhancement/npmize branch from bde0cd5 to 44c50a2Compare December 20, 2018 17:01

ChristophWurst added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Dec 20, 2018

ChristophWurst requested review from rullzer and skjnldsv December 20, 2018 17:10

skjnldsv reviewed Dec 20, 2018
View reviewed changes

Comment threadpackage.json

skjnldsv reviewed Dec 20, 2018
View reviewed changes

Comment threadcore/src/globals.js

rullzer approved these changes Dec 20, 2018
View reviewed changes

This comment has been minimized.
Sign in to view

This was referenced Dec 21, 2018
Move build dependencies to main package.json #13203
Closed
Use webpack/sass-loader to precompile scss files #13204
Closed
Use webpack+handlebars-loader for the Handlebars precompilation #13205
Closed

This comment has been minimized.
Sign in to view

skjnldsv approved these changes Dec 21, 2018
View reviewed changes

skjnldsv reviewed Dec 21, 2018
View reviewed changes

ChristophWurstand others added 8 commits January 9, 2019 15:02

Don't load old vendor files during jsunit tests
01a6181
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Adjust release file list
69410a4
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Use jquery-ui-dist instead of jquery-ui to resolve an issue with …
15400fc
…effects Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Mergejs is gone
a340273
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Update select2, include css
83068c3
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Override select2 lib styling
dbee410
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

Use upstream strengthify lib
e4e5cf8
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Fix select2 style preference
96102c1
Signed-off-by: Julius Härtl <jus@bitgrid.net>

juliusknorr force-pushed the enhancement/npmize branch from d5c6cf8 to 96102c1Compare January 9, 2019 14:13

juliusknorr approved these changes Jan 9, 2019
View reviewed changes

This comment has been minimized.
Sign in to view

tcitworld reviewed Jan 9, 2019
View reviewed changes

MorrisJobke added this to the Nextcloud 16 milestone Jan 9, 2019

This comment has been minimized.
Sign in to view

MorrisJobke approved these changes Jan 9, 2019
View reviewed changes

MorrisJobke added 2. developing Work in progress and removed 4. to release Ready to be released and/or waiting for tests to finish labels Jan 9, 2019

Bump select2 from 3.4.5 to 3.4.8
1728075
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Jan 9, 2019

rullzer merged commit 011aab5 into masterJan 9, 2019

rullzer deleted the enhancement/npmize branch January 9, 2019 19:16

MorrisJobke mentioned this pull request Mar 5, 2019
Use underscore.min.js #8450
Closed

ChristophWurst mentioned this pull request Sep 5, 2019
Install Select2 via npm #17023
Merged

Uh oh!

Uh oh!

Conversation

ChristophWurst commented Dec 19, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

rullzer commented Dec 19, 2018

Uh oh!

ChristophWurst commented Dec 19, 2018

Uh oh!

ChristophWurst commented Dec 19, 2018

Uh oh!

rullzer commented Dec 19, 2018

Uh oh!

ChristophWurst commented Dec 20, 2018

Uh oh!

ChristophWurst commented Dec 20, 2018

Uh oh!

ChristophWurst commented Dec 20, 2018

Uh oh!

Uh oh!

Uh oh!

rullzer commented Dec 20, 2018

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

skjnldsvDec 21, 2018

Choose a reason for hiding this comment

Uh oh!

ChristophWurstDec 21, 2018

Choose a reason for hiding this comment

Uh oh!

juliusknorr commented Jan 9, 2019

Uh oh!

This comment has been minimized.

tcitworldJan 9, 2019

Choose a reason for hiding this comment

Uh oh!

ChristophWurstJan 9, 2019

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

MorrisJobke left a comment

Choose a reason for hiding this comment

Uh oh!

ChristophWurst commented Jan 9, 2019

Uh oh!

MorrisJobke commented Jan 9, 2019

Uh oh!

MorrisJobke commented Jan 9, 2019

Uh oh!

coliff commented Mar 5, 2019

Uh oh!

ChristophWurst commented Mar 5, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

ChristophWurst commented Dec 19, 2018•
edited
Loading