Uh oh!
There was an error while loading. Please reload this page.
Install Select2 via npm - #17023
Merged
Merged
Conversation
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
requested review from
GretaD, danxuliu, georgehrke, juliusknorr and skjnldsvSeptember 5, 2019 15:32
skjnldsv
approved these changes
Sep 5, 2019
Member
I think it is used by other apps ^^' |
ChristophWurst
commented
Sep 5, 2019
MemberAuthor
Yeah. Would be pretty awesome if we tested at least with one app :) |
GretaD
approved these changes
Sep 5, 2019
juliusknorr
approved these changes
Sep 7, 2019
juliusknorr
left a comment
Member
There was a problem hiding this comment.
Tagging and the workflow app still use it 😉 Just tested and it seems to be working as before.
skjnldsv
commented
Sep 8, 2019
Member
I'll see what I can do about tagging for 18 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #16956 (comment)
There was something about Select2 that made me install via git at #13156, but I can't remember what version at that time cause the problems.
@nextcloud/javascript where do we even use it? Couldn't find a single usage in server :)