Skip to content

improve lookup server behaviour - #13401

Merged
rullzer merged 2 commits into
masterfrom
improve-lookup-server-behaviour
Mar 4, 2019
Merged

improve lookup server behaviour#13401
rullzer merged 2 commits into
masterfrom
improve-lookup-server-behaviour

Conversation

@schiessle

@schiessleschiessle commented Jan 7, 2019

Copy link
Copy Markdown
Member

Don't try to connect to the lookup server if the lookup server was disabled
by the admin or an empty lookup server URL was given

fix#13396

Additionally we should consider to add a background job which clean existing data from the lookup sever once the admin disabled it, see #13396 (comment)

@schiessle
improve lookup server behaviour
d413498
Don't try to connect to the lookup server if the lookup server was disabled
by the admin or an empty lookup server URL was given
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
MorrisJobke
MorrisJobke reviewed Jan 7, 2019
View reviewed changes
Comment threadapps/lookup_server_connector/lib/BackgroundJobs/RetryJob.php
@MorrisJobkeMorrisJobke added 3. to review Waiting for reviews bug labels Jan 7, 2019
rullzer
rullzer reviewed Jan 7, 2019
View reviewed changes
Comment threadapps/lookup_server_connector/lib/BackgroundJobs/RetryJob.php
@rullzer

rullzer commented Jan 29, 2019

Copy link
Copy Markdown
Member

@schiessle ping

@schiessle
increase timespan between each retry
f6b0a65
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
@schiessle

schiessle commented Feb 21, 2019

Copy link
Copy Markdown
MemberAuthor

@rullzer from my pov this is ready to go in after my last commits from yesterday

@MorrisJobkeMorrisJobke mentioned this pull request Mar 4, 2019
Merged
45 tasks
MorrisJobke
MorrisJobke approved these changes Mar 4, 2019
View reviewed changes

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code makes sense 👍

@MorrisJobke

MorrisJobke commented Mar 4, 2019

Copy link
Copy Markdown
Member

CI failure unrelated

rullzer
rullzer approved these changes Mar 4, 2019
View reviewed changes

@rullzerrullzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets do this then

@rullzer
rullzer merged commit 138fdf0 into masterMar 4, 2019
@rullzer
rullzer deleted the improve-lookup-server-behaviour branch March 4, 2019 13:25
@kesselbkesselb mentioned this pull request Mar 4, 2019
Merged
@MorrisJobkeMorrisJobke mentioned this pull request Mar 5, 2019
Merged
@rullzer

rullzer commented Mar 14, 2019

Copy link
Copy Markdown
Member

Should we backport this? I guess it would make sense.

@MorrisJobke

MorrisJobke commented Mar 14, 2019

Copy link
Copy Markdown
Member

/backport to stable15

@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Mar 14, 2019
Merged
@backportbot-nextcloud

backportbot-nextcloudBot commented Mar 14, 2019

Copy link
Copy Markdown

backport to stable15 in #14696

@solracsfsolracsf mentioned this pull request Apr 17, 2021
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzerrullzerrullzer approved these changes
@MorrisJobkeMorrisJobkeMorrisJobke approved these changes
@blizzzblizzzAwaiting requested review from blizzz
@nickvergessennickvergessenAwaiting requested review from nickvergessen

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewsbug

Projects

None yet

Milestone

Nextcloud 16

Development

Successfully merging this pull request may close these issues.

lookup_server_connector creates a lot of oc_jobs entries, high DB load during cron, and tries to sync even if disabled in options

4 participants

@schiessle@rullzer@MorrisJobke@blizzz