Skip to content

[stable15] improve lookup server behaviour - #14696

Merged
rullzer merged 4 commits into
stable15from
backport/13401/stable15
Mar 18, 2019
Merged

[stable15] improve lookup server behaviour#14696
rullzer merged 4 commits into
stable15from
backport/13401/stable15

Conversation

@backportbot-nextcloud

@backportbot-nextcloudbackportbot-nextcloudBot commented Mar 14, 2019

Copy link
Copy Markdown

backport of #13401

@backportbot-nextcloudbackportbot-nextcloudBot added this to the Nextcloud 15.0.6 milestone Mar 14, 2019
@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Mar 14, 2019
Merged
@MorrisJobkeMorrisJobke added the 3. to review Waiting for reviews label Mar 14, 2019
rullzer
rullzer approved these changes Mar 14, 2019
View reviewed changes

@rullzerrullzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@rullzerrullzer added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 14, 2019
@nextcloudnextcloud deleted a comment from faily-botBotMar 15, 2019
@schiessle@rullzer
improve lookup server behaviour
23c57b2
Don't try to connect to the lookup server if the lookup server was disabled
by the admin or an empty lookup server URL was given
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
@schiessle@rullzer
increase timespan between each retry
edbe99d
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
@rullzer
rullzerforce-pushed the backport/13401/stable15 branch from c89cb30 to edbe99dCompareMarch 17, 2019 19:39
@MorrisJobke

MorrisJobke commented Mar 17, 2019

Copy link
Copy Markdown
Member
[Sun Mar 17 19:52:15 2019] Undefined property: OCA\LookupServerConnector\UpdateLookupServer::$config at /drone/src/github.com/nextcloud/server/apps/lookup_server_connector/lib/UpdateLookupServer.php#73
[Sun Mar 17 19:52:15 2019] Error: Call to a member function getAppValue() on null at /drone/src/github.com/nextcloud/server/apps/lookup_server_connector/lib/UpdateLookupServer.php#73

🙈

kesselband others added 2 commits March 18, 2019 08:33
@kesselb@rullzer
Fix Undefined property: OCA\LookupServerConnector\UpdateLookupServer:…
6e56160
…:$config
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@MorrisJobke@rullzer
Fix missing $config dependency in RetryJob
ee64260
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@rullzer

rullzer commented Mar 18, 2019

Copy link
Copy Markdown
Member

Also applied #14519 and #14529

@faily-bot

faily-botBot commented Mar 18, 2019

Copy link
Copy Markdown

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 17110: failure

TESTS=acceptance, TESTS-ACCEPTANCE=app-comments

  • cancelled - typically means that the tests took longer than the drone CI allows them to run

TESTS=acceptance, TESTS-ACCEPTANCE=app-files-sharing

  • cancelled - typically means that the tests took longer than the drone CI allows them to run

@rullzer
rullzer merged commit 3f559dd into stable15Mar 18, 2019
@rullzer
rullzer deleted the backport/13401/stable15 branch March 18, 2019 09:07
@rullzerrullzer mentioned this pull request Mar 29, 2019
Merged
1 task
@tfliddtflidd mentioned this pull request Jun 27, 2019
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzerrullzerrullzer approved these changes
@MorrisJobkeMorrisJobkeMorrisJobke approved these changes
@blizzzblizzzAwaiting requested review from blizzz
@nickvergessennickvergessenAwaiting requested review from nickvergessen
@schiessleschiessleAwaiting requested review from schiessle

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finishbug

Projects

None yet

Milestone

Nextcloud 15.0.6

Development

Successfully merging this pull request may close these issues.

4 participants

@MorrisJobke@rullzer@schiessle@kesselb