Skip to content

Split main js files into modules and add them to the server bundle - #13635

Closed
ChristophWurst wants to merge 1 commit into
masterfrom
refactor/core-js-bundle
Closed

Split main js files into modules and add them to the server bundle#13635
ChristophWurst wants to merge 1 commit into
masterfrom
refactor/core-js-bundle

Conversation

@ChristophWurst

Copy link
Copy Markdown
Member

No description provided.

@ChristophWurstChristophWurst added this to the Nextcloud 16 milestone Jan 16, 2019
@ChristophWurstChristophWurst self-assigned this Jan 16, 2019
@ChristophWurst

Copy link
Copy Markdown
MemberAuthor

Loading the files app on master: 104 js files loaded
this branch: 89

And I'm not even done 🚀

@ChristophWurst

Copy link
Copy Markdown
MemberAuthor

I think I might stop at this point before this gets even less reviewable. It's possible to do this transition in another one or two PRs.

@ChristophWurst

Copy link
Copy Markdown
MemberAuthor
  • BUG: after a local file is selected for upload, nothing happens. no error, no upload, no visual changes.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst

Copy link
Copy Markdown
MemberAuthor

@juliushaertl I've rebased onto master to resolve conflicts from #13407. Please have a look if I applied the changes correctly (should you find them in this huge diff).

Comment threadcore/src/globals.js
import OCA from './oca';
import escapeHTML from './util/escapeHTML'
import './jquery.avatar';
import './jquery.contactsmenu';

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about having a separate chunk for code that is only required when a user is logged in?
Besides the contactsmenu, when looking at core.json we probably also don't need to load systemtags/setupchecks on public pages.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good! We can definitely try to load them only if required. We just have to check if the code still runs 😉

@juliusknorr

Copy link
Copy Markdown
Member

@juliushaertl I've rebased onto master to resolve conflicts from #13407. Please have a look if I applied the changes correctly (should you find them in this huge diff).

Looks good.

@ChristophWurst

Copy link
Copy Markdown
MemberAuthor

Thanks for checking! I've now also added folders in src for OCA and OCP. I like what you did with OC on the other branch. This keeps the scripts a bit more organized :)

@ChristophWurst

Copy link
Copy Markdown
MemberAuthor

Alright, this introduced a little 🐛 I'm unable to find 🔍. I'll do this in a bunch of smaller, more reviewable PRs :)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2. developingWork in progressenhancementtechnical debt🧱 🤔🚀

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@ChristophWurst@juliusknorr