Skip to content

Make appstore app:enable test more robust by repeating if it fails on the first try - #14668

Merged
MorrisJobke merged 1 commit into
masterfrom
fix/noid/make-appstore-test-more-stable
Mar 14, 2019
Merged

Make appstore app:enable test more robust by repeating if it fails on the first try#14668
MorrisJobke merged 1 commit into
masterfrom
fix/noid/make-appstore-test-more-stable

Conversation

@MorrisJobke

Copy link
Copy Markdown
Member

Fixes the issue from #14640 (comment)

@MorrisJobkeMorrisJobke added the 3. to review Waiting for reviews label Mar 13, 2019
@MorrisJobkeMorrisJobke added this to the Nextcloud 16 milestone Mar 13, 2019
@MorrisJobke

Copy link
Copy Markdown
MemberAuthor

/backport to stable15

@MorrisJobke

Copy link
Copy Markdown
MemberAuthor

/backport to stable14

@kesselb

Copy link
Copy Markdown
Contributor

Backport will fail because the tests are new. The test only works if app store is available and there is a release of the contacts app. Tests will fail again if you bump version to 17. I think we should disable the tests with the contact app for now.

Comment threadtests/Core/Command/Apps/AppsEnableTest.php Outdated
@MorrisJobke
MorrisJobkeforce-pushed the fix/noid/make-appstore-test-more-stable branch from 1149cd4 to 2d02f54CompareMarch 14, 2019 10:46
@MorrisJobke

Copy link
Copy Markdown
MemberAuthor

@kesselb I changed the app to a shipped one.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke
MorrisJobkeforce-pushed the fix/noid/make-appstore-test-more-stable branch from 2d02f54 to 5b4155bCompareMarch 14, 2019 12:39
@MorrisJobkeMorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 14, 2019
@faily-bot

faily-botBot commented Mar 14, 2019

Copy link
Copy Markdown

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 16990: failure

TESTS=acceptance, TESTS-ACCEPTANCE=apps

  • tests/acceptance/features/apps.feature:75
  • tests/acceptance/features/apps.feature:83
Show full log
 Scenario: View app details for app store apps # /drone/src/github.com/nextcloud/server/tests/acceptance/features/apps.feature:75
Given I act as Jane # ActorContext::iActAs()
And I am logged in as the admin # LoginPageContext::iAmLoggedInAsTheAdmin()
And I open the Apps management # SettingsMenuContext::iOpenTheAppsManagement()
And I open the "Tools" section # AppNavigationContext::iOpenTheSection()
When I click on the "Antivirus for files" app # AppsManagementContext::iClickOnTheApp()
Row for app Antivirus for files in Apps Management could not be found after 100 seconds (NoSuchElementException)
Then I see that the app details are shown # AppsManagementContext::iSeeThatTheAppDetailsAreShown()
Scenario: Install an app from the app store # /drone/src/github.com/nextcloud/server/tests/acceptance/features/apps.feature:83
Given I act as Jane # ActorContext::iActAs()
And I am logged in as the admin # LoginPageContext::iAmLoggedInAsTheAdmin()
And I open the Apps management # SettingsMenuContext::iOpenTheAppsManagement()
And I open the "Tools" section # AppNavigationContext::iOpenTheSection()
Tools section item in App Navigation could not be found after 100 seconds (NoSuchElementException)
And I click on the "Antivirus for files" app # AppsManagementContext::iClickOnTheApp()
And I see that the app details are shown # AppsManagementContext::iSeeThatTheAppDetailsAreShown()
Then I download and enable the "Antivirus for files" app # AppsManagementContext::iDownloadAndEnableTheApp()
And I see that the "Antivirus for files" app has been enabled # AppsManagementContext::iSeeThatTheAppHasBeenEnabled()

@MorrisJobke

Copy link
Copy Markdown
MemberAuthor

TESTS=acceptance, TESTS-ACCEPTANCE=apps

  • tests/acceptance/features/apps.feature:75
  • tests/acceptance/features/apps.feature:83

Commented in 70f90b8 in #14681

@MorrisJobke
MorrisJobke merged commit b7ffbcd into masterMar 14, 2019
@MorrisJobke
MorrisJobke deleted the fix/noid/make-appstore-test-more-stable branch March 14, 2019 15:19
@backportbot-nextcloud

Copy link
Copy Markdown

The backport to stable15 failed. Please do this backport manually.

@backportbot-nextcloud

Copy link
Copy Markdown

The backport to stable14 failed. Please do this backport manually.

@MorrisJobke

Copy link
Copy Markdown
MemberAuthor

No need to back port - the command was added to 16.

@MorrisJobkeMorrisJobke mentioned this pull request Mar 20, 2019
9 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finish

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@MorrisJobke@kesselb@rullzer