Skip to content

Disable fragile tests - part 2 - #14681

Merged
MorrisJobke merged 5 commits into
masterfrom
forwardport/noid/fragile-tests
Mar 14, 2019
Merged

Disable fragile tests - part 2#14681
MorrisJobke merged 5 commits into
masterfrom
forwardport/noid/fragile-tests

Conversation

@MorrisJobke

@MorrisJobkeMorrisJobke commented Mar 14, 2019

Copy link
Copy Markdown
Member

Found while back porting #14640 (#14673#14672)

@MorrisJobke
Disable failing files app test - act 2
43e9006
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke
Disable failing comments app test - act 2
caea04d
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobkeMorrisJobke added the 3. to review Waiting for reviews label Mar 14, 2019
@MorrisJobkeMorrisJobke added this to the Nextcloud 16 milestone Mar 14, 2019
@faily-bot

faily-botBot commented Mar 14, 2019

Copy link
Copy Markdown

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 16995: failure

TESTS=acceptance, TESTS-ACCEPTANCE=app-files

  • tests/acceptance/features/app-files.feature:239
Show full log
 Scenario: rename a file with the details view open # /drone/src/github.com/nextcloud/server/tests/acceptance/features/app-files.feature:239
Given I am logged in # LoginPageContext::iAmLoggedIn()
And I open the details view for "welcome.txt" # FileListContext::iOpenTheDetailsViewFor()
When I rename "welcome.txt" to "farewell.txt" # FileListContext::iRenameTo()
Rename input for file welcome.txt in file list could not be found after 100 seconds (NoSuchElementException)
Then I see that the file list contains a file named "farewell.txt" # FileListContext::iSeeThatTheFileListContainsAFileNamed()
And I see that the file name shown in the details view is "farewell.txt" # FilesAppContext::iSeeThatTheFileNameShownInTheDetailsViewIs()

@MorrisJobke
Disable failing app management test
70f90b8
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobkeMorrisJobke mentioned this pull request Mar 14, 2019
Merged
@MorrisJobke
Disable failing files app test - act 3
951dcc1
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke
Disable failing files app test - act 4
1d93894
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke

MorrisJobke commented Mar 14, 2019

Copy link
Copy Markdown
MemberAuthor

Backports of this are in #14673 and #14672 already

This was referenced Mar 14, 2019
Merged
Merged
ChristophWurst
ChristophWurst approved these changes Mar 14, 2019
View reviewed changes

@ChristophWurstChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙊 🙈 🙉

@MorrisJobkeMorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 14, 2019
@MorrisJobkeMorrisJobke mentioned this pull request Mar 14, 2019
Merged
@MorrisJobke
MorrisJobke merged commit bfe2c19 into masterMar 14, 2019
@MorrisJobke
MorrisJobke deleted the forwardport/noid/fragile-tests branch March 14, 2019 22:30
This was referenced Mar 14, 2019
Merged
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzerrullzerrullzer approved these changes
@ChristophWurstChristophWurstChristophWurst approved these changes
@danxuliudanxuliuAwaiting requested review from danxuliu

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finish

Projects

None yet

Milestone

Nextcloud 16

Development

Successfully merging this pull request may close these issues.

3 participants

@MorrisJobke@rullzer@ChristophWurst