Skip to content

add casting to string for postgresql query builder - #14683

Merged
MorrisJobke merged 1 commit into
masterfrom
postgres-cast-string
Mar 14, 2019
Merged

add casting to string for postgresql query builder#14683
MorrisJobke merged 1 commit into
masterfrom
postgres-cast-string

Conversation

@icewind1991

Copy link
Copy Markdown
Member

Signed-off-by: Robin Appelman robin@icewind.nl

Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991icewind1991 added the 3. to review Waiting for reviews label Mar 14, 2019
@icewind1991icewind1991 added this to the Nextcloud 16 milestone Mar 14, 2019

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code makes sense 👍

@rullzerrullzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@MorrisJobkeMorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 14, 2019
@faily-bot

faily-botBot commented Mar 14, 2019

Copy link
Copy Markdown

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 16997: failure

TESTS=acceptance, TESTS-ACCEPTANCE=apps

  • tests/acceptance/features/apps.feature:83
Show full log
 Scenario: Install an app from the app store # /drone/src/github.com/nextcloud/server/tests/acceptance/features/apps.feature:83
Given I act as Jane # ActorContext::iActAs()
And I am logged in as the admin # LoginPageContext::iAmLoggedInAsTheAdmin()
And I open the Apps management # SettingsMenuContext::iOpenTheAppsManagement()
And I open the "Tools" section # AppNavigationContext::iOpenTheSection()
Tools section item in App Navigation could not be found after 100 seconds (NoSuchElementException)
And I click on the "Antivirus for files" app # AppsManagementContext::iClickOnTheApp()
And I see that the app details are shown # AppsManagementContext::iSeeThatTheAppDetailsAreShown()
Then I download and enable the "Antivirus for files" app # AppsManagementContext::iDownloadAndEnableTheApp()
And I see that the "Antivirus for files" app has been enabled # AppsManagementContext::iSeeThatTheAppHasBeenEnabled()

@MorrisJobke

Copy link
Copy Markdown
Member
  • tests/acceptance/features/apps.feature:83

"fixed" in #14681

@MorrisJobke
MorrisJobke merged commit 2204d41 into masterMar 14, 2019
@MorrisJobke
MorrisJobke deleted the postgres-cast-string branch March 14, 2019 15:45
@MorrisJobkeMorrisJobke mentioned this pull request Mar 20, 2019
9 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finish

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@icewind1991@MorrisJobke@rullzer