Uh oh!
There was an error while loading. Please reload this page.
Always register the Notifier - #14744
Merged
ChristophWurst merged 1 commit intoMar 19, 2019
Merged
Conversation
... so background jobs without a user can prepare push notifications Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
commented
Mar 19, 2019
MemberAuthor
/backport to stable15 |
nickvergessen
commented
Mar 19, 2019
MemberAuthor
/backport to stable14 |
tacruc
reviewed
Mar 19, 2019
| // Since notifications also work for non-admins we don't check this here. | ||
| $this->registerNotifier(); | ||
| } else if ($server->getGroupManager()->isAdmin($user->getUID())) { | ||
| if (!$server->getAppManager()->isEnabledForUser('notifications') && |
Contributor
There was a problem hiding this comment.
Why is updateChecker only checked if the notifications is not enabled for Users?
MemberAuthor
There was a problem hiding this comment.
Because if you receive a notification, we do not show the JS popup. It is basically the fallback for when you dont have notifications enabled.
ChristophWurst
approved these changes
Mar 19, 2019
ChristophWurst
deleted the
bugfix/noid/fix-push-notifications-for-updatenotifications
branch
March 19, 2019 15:42
backport to stable15 in #14749 |
tobiasKaminsky
commented
Mar 21, 2019
Member
I applied this manually on NC15 and got yesterday evening a push notification with an info about update of collabora 🎉 Thank you for finding the problem @nickvergessen |
nickvergessen
commented
Mar 21, 2019
MemberAuthor
/backport to stable14 |
backport to stable14 in #14783 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... so background jobs without a user can prepare push notifications