Skip to content

[stable15] Always register the Notifier - #14749

Merged
rullzer merged 1 commit into
stable15from
backport/14744/stable15
Mar 20, 2019
Merged

[stable15] Always register the Notifier#14749
rullzer merged 1 commit into
stable15from
backport/14744/stable15

Conversation

@backportbot-nextcloud

Copy link
Copy Markdown

backport of #14744

... so background jobs without a user can prepare push notifications
Signed-off-by: Joas Schilling <coding@schilljs.com>
@faily-bot

faily-botBot commented Mar 19, 2019

Copy link
Copy Markdown

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 17148: failure

TESTS=acceptance, TESTS-ACCEPTANCE=app-comments

  • tests/acceptance/features/app-comments.feature:171
Show full log
 Scenario: unread comment icon shown for comment written by the sharer in a child folder of a shared folder # /drone/src/github.com/nextcloud/server/tests/acceptance/features/app-comments.feature:171
Given I act as John # ActorContext::iActAs()
And I am logged in as the admin # LoginPageContext::iAmLoggedInAsTheAdmin()
And I act as Jane # ActorContext::iActAs()
And I am logged in # LoginPageContext::iAmLoggedIn()
And I act as John # ActorContext::iActAs()
And I create a new folder named "Folder" # FileListContext::iCreateANewFolderNamed()
And I share "Folder" with "user0" # FilesAppSharingContext::iShareWith()
│ Share with input in the details view in Files app value could not be set
│ Exception message: Element is not currently visible and so may not be interacted with
│ Build info: version: '2.53.1', revision: 'a36b8b1', time: '2016-06-30 17:37:03'
│ System info: host: 'd9a1dbdec2bb', ip: '172.17.0.8', os.name: 'Linux', os.arch: 'amd64', os.version: '4.15.0-43-generic', java.version: '1.8.0_91'
│ Driver info: driver.version: unknown
│ Trying again
│ And I see that the file is shared with "user0" # FilesAppSharingContext::iSeeThatTheFileIsSharedWith()
And I enter in the folder named "Folder" # FileListContext::iEnterInTheFolderNamed()
And I create a new folder named "Child folder" # FileListContext::iCreateANewFolderNamed()
And I open the "Comments" tab in the details view # FilesAppContext::iOpenTheTabInTheDetailsView()
│ Tab header named Comments in details view in Files app could not be clicked
│ Exception message: Offset within element cannot be scrolled into view: (0, 0): [object HTMLLIElement]
│ Build info: version: '2.53.1', revision: 'a36b8b1', time: '2016-06-30 17:37:03'
│ System info: host: 'd9a1dbdec2bb', ip: '172.17.0.8', os.name: 'Linux', os.arch: 'amd64', os.version: '4.15.0-43-generic', java.version: '1.8.0_91'
│ Driver info: driver.version: unknown
│ Trying again
│ Offset within element cannot be scrolled into view: (89, 22.5): [object HTMLLIElement]
Build info: version: '2.53.1', revision: 'a36b8b1', time: '2016-06-30 17:37:03'
System info: host: 'd9a1dbdec2bb', ip: '172.17.0.8', os.name: 'Linux', os.arch: 'amd64', os.version: '4.15.0-43-generic', java.version: '1.8.0_91'
Driver info: driver.version: unknown (WebDriver\Exception\MoveTargetOutOfBounds)
And I create a new comment with "Hello world" as message # CommentsAppContext::iCreateANewCommentWithAsMessage()
And I see a comment with "Hello world" as message # CommentsAppContext::iSeeACommentWithAsMessage()
When I act as Jane # ActorContext::iActAs()
And I open the Files app # FilesAppContext::iOpenTheFilesApp()
And I enter in the folder named "Folder" # FileListContext::iEnterInTheFolderNamed()
Then I see that "Child folder" has unread comments # FileListContext::iSeeThatHasUnreadComments()
And I open the unread comments for "Child folder" # FileListContext::iOpenTheUnreadCommentsFor()
And I see that the details view is open # FilesAppContext::iSeeThatTheDetailsViewIsOpen()
And I see a comment with "Hello world" as message # CommentsAppContext::iSeeACommentWithAsMessage()

@ChristophWurstChristophWurst added the 4. to release Ready to be released and/or waiting for tests to finish label Mar 20, 2019
@rullzer
rullzer merged commit d211d5e into stable15Mar 20, 2019
@rullzer
rullzer deleted the backport/14744/stable15 branch March 20, 2019 09:05
@rullzerrullzer mentioned this pull request Mar 29, 2019
1 task
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishbugfeature: activity and notification

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@rullzer@ChristophWurst@nickvergessen