Uh oh!
There was an error while loading. Please reload this page.
add "askForPassword" on capabilities for sharing - #15461
Merged
Merged
Conversation
kesselb
reviewed
May 9, 2019
Uh oh!
There was an error while loading. Please reload this page.
rullzer
reviewed
May 9, 2019
Uh oh!
There was an error while loading. Please reload this page.
Merged
1 task
tobiasKaminskyforce-pushed
the
askForPasswordCapability
branch
2 times, most recently
from
May 10, 2019 06:19
ccb144c to
0df2056Comparekesselb
approved these changes
May 11, 2019
kesselb
left a comment
Contributor
There was a problem hiding this comment.
LGTM. We could save another call here by reusing $public['password']['enforced'].
Uh oh!
There was an error while loading. Please reload this page.
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
MorrisJobkeforce-pushed
the
askForPasswordCapability
branch
from
May 13, 2019 18:09
0df2056 to
b65a595CompareMorrisJobke
approved these changes
May 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed for #15459
This exposes "askForPassword" capability on file_sharing:
If password is enforced, askForPassword will be false.
Signed-off-by: tobiasKaminsky tobias@kaminsky.me