Skip to content

Add strict type on Notifications tests - #15935

Merged
skjnldsv merged 1 commit into
masterfrom
fix/tests/notifications
Jun 14, 2019
Merged

Add strict type on Notifications tests#15935
skjnldsv merged 1 commit into
masterfrom
fix/tests/notifications

Conversation

@skjnldsv

@skjnldsvskjnldsv commented Jun 12, 2019•
edited
Loading

Copy link
Copy Markdown
Member

@skjnldsvskjnldsv added bug 3. to review Waiting for reviews labels Jun 12, 2019
@skjnldsvskjnldsv added this to the Nextcloud 17 milestone Jun 12, 2019
@skjnldsvskjnldsv self-assigned this Jun 12, 2019
@georgehrke

georgehrke commented Jun 12, 2019

Copy link
Copy Markdown
Member

I think we should add strict return types as well. :)

@skjnldsv

skjnldsv commented Jun 12, 2019

Copy link
Copy Markdown
MemberAuthor

I think we should add strict return types as well. :)

Do_it_shia_laboeuf.gif

ChristophWurst
ChristophWurst reviewed Jun 12, 2019
View reviewed changes
Comment threadlib/public/Notification/INotification.php
@juliusknorr

juliusknorr commented Jun 13, 2019

Copy link
Copy Markdown
Member

Two remaining 😉

1) OCA\Comments\Tests\Unit\Controller\NotificationsTest::testViewSuccess
133 | TypeError: Argument 1 passed to Mock_INotification_fc0f9ea9::setUser() must be of the type string, null given, called in /drone/src/apps/comments/lib/Controller/Notifications.php on line 145
134 | 135 | /drone/src/apps/comments/lib/Controller/Notifications.php:145
136 | /drone/src/apps/comments/lib/Controller/Notifications.php:118
137 | /drone/src/apps/comments/tests/Unit/Controller/NotificationsTest.php:153
138 | 139 | 2) OCA\Comments\Tests\Unit\Controller\NotificationsTest::testViewNoFile
140 | TypeError: Argument 1 passed to Mock_INotification_fc0f9ea9::setUser() must be of the type string, null given, called in /drone/src/apps/comments/lib/Controller/Notifications.php on line 145
141 | 142 | /drone/src/apps/comments/lib/Controller/Notifications.php:145
143 | /drone/src/apps/comments/lib/Controller/Notifications.php:118
144 | /drone/src/apps/comments/tests/Unit/Controller/NotificationsTest.php:216
145

@skjnldsv
Add strict type on Notifications tests
e9351ef
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
skjnldsvforce-pushed the fix/tests/notifications branch from 843f0d0 to e9351efCompareJune 13, 2019 12:58
@skjnldsv

skjnldsv commented Jun 13, 2019

Copy link
Copy Markdown
MemberAuthor

Done!

@skjnldsvskjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 14, 2019
@skjnldsv
skjnldsv merged commit bf18f1e into masterJun 14, 2019
@skjnldsv
skjnldsv deleted the fix/tests/notifications branch June 14, 2019 12:12
@blizzz

blizzz commented Jun 17, 2019

Copy link
Copy Markdown
Member

Also needs backports, doesn't it ?

@skjnldsv

skjnldsv commented Jun 19, 2019

Copy link
Copy Markdown
MemberAuthor

Yes!

@skjnldsv

skjnldsv commented Jun 19, 2019

Copy link
Copy Markdown
MemberAuthor

/backport to stable16

@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Jun 19, 2019
Closed
@backportbot-nextcloud

backportbot-nextcloudBot commented Jun 19, 2019

Copy link
Copy Markdown

backport to stable16 in #16014

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurstChristophWurstChristophWurst approved these changes
@juliusknorrjuliusknorrjuliusknorr approved these changes
@nickvergessennickvergessenAwaiting requested review from nickvergessen
@georgehrkegeorgehrkeAwaiting requested review from georgehrke

Assignees

@skjnldsvskjnldsv

Labels

4. to releaseReady to be released and/or waiting for tests to finishbug

Projects

None yet

Milestone

Nextcloud 17

Development

Successfully merging this pull request may close these issues.

5 participants

@skjnldsv@georgehrke@juliusknorr@blizzz@ChristophWurst