Skip to content

[stable16] Add strict type on Notifications tests - #16014

Closed
backportbot-nextcloud[bot] wants to merge 1 commit into
stable16from
backport/15935/stable16
Closed

[stable16] Add strict type on Notifications tests#16014
backportbot-nextcloud[bot] wants to merge 1 commit into
stable16from
backport/15935/stable16

Conversation

@backportbot-nextcloud

@backportbot-nextcloudbackportbot-nextcloudBot commented Jun 19, 2019

Copy link
Copy Markdown

backport of #15935

@skjnldsvBackportbot
Add strict type on Notifications tests
09fa2c6
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@backportbot-nextcloudbackportbot-nextcloudBot added this to the Nextcloud 16.0.2 milestone Jun 19, 2019
@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Jun 19, 2019
Merged
@skjnldsvskjnldsv added the 3. to review Waiting for reviews label Jun 19, 2019
@skjnldsv

skjnldsv commented Jun 19, 2019

Copy link
Copy Markdown
Member

Fixes broken stable16 NODB tests

@skjnldsv
skjnldsv requested a review from blizzzJune 19, 2019 13:38
@skjnldsvskjnldsv mentioned this pull request Jun 19, 2019
Merged
@nickvergessen

nickvergessen commented Jun 21, 2019

Copy link
Copy Markdown
Member

why are we backporting type hints on public interfaces? That will break all tests of apps...

@skjnldsv

skjnldsv commented Jun 21, 2019

Copy link
Copy Markdown
Member

@nickvergessen because that seemed like a bug ore than a feature? 🙈

@skjnldsvskjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 21, 2019
@nickvergessen

nickvergessen commented Jun 21, 2019

Copy link
Copy Markdown
Member

Yeah well, doesn't matter. We don't backport breaking the APIs.

We will fix the type hints for 17, for 16 only the cast should be backported and all other changes reverted.

@skjnldsv

skjnldsv commented Jun 21, 2019

Copy link
Copy Markdown
Member

Sorry about that!
So we merge this?

@georgehrke

georgehrke commented Jun 21, 2019

Copy link
Copy Markdown
Member

Keep all the casting (or add additional ones), but remove all the type hints

@skjnldsv

skjnldsv commented Jun 21, 2019

Copy link
Copy Markdown
Member

Well, this one just fixes the tests.
All the edits are already in

@georgehrke

georgehrke commented Jun 21, 2019

Copy link
Copy Markdown
Member

I guess we should revert the back port of the other PR before releasing the next version then.

cc @nickvergessen

@nickvergessen

nickvergessen commented Jun 21, 2019

Copy link
Copy Markdown
Member

I guess we should revert the back port of the other PR before releasing the next version then.

Yes, exactly. Revert the backport and just keep the casting or make a new commit with the casting:
https://github.com/nextcloud/server/pull/15912/files#diff-ea411f2ca6aeb5624cef170048c91d67R199

Only this one line is necessary to be backported.

@rullzerrullzer mentioned this pull request Jun 24, 2019
Merged
5 tasks
@skjnldsv
skjnldsv requested a review from rullzerJune 25, 2019 10:28
@rullzer

rullzer commented Jun 25, 2019

Copy link
Copy Markdown
Member

#16068 is the fix... let have this die

@rullzerrullzer closed this Jun 25, 2019
@rullzer
rullzer deleted the backport/15935/stable16 branch June 25, 2019 10:42
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurstChristophWurstChristophWurst approved these changes
@skjnldsvskjnldsvskjnldsv approved these changes
@georgehrkegeorgehrkeAwaiting requested review from georgehrke
@juliusknorrjuliusknorrAwaiting requested review from juliusknorr
@nickvergessennickvergessenAwaiting requested review from nickvergessen
@blizzzblizzzAwaiting requested review from blizzz
@rullzerrullzerAwaiting requested review from rullzer

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finishbug

Projects

None yet

Milestone

Nextcloud 16.0.2

Development

Successfully merging this pull request may close these issues.

5 participants

@skjnldsv@nickvergessen@georgehrke@rullzer@ChristophWurst