files_external: proper user context for sharing

[juliusknorr]

This will make sure we also have a proper user context for non-logged in users that access the instance though share links. Otherwise the file system setup doesn't work properly for share links, if either a $home or $user variable is configured for substitution.

Steps to reproduce:

• Configure external storage mounted to / with $user contained in the path
• Try to access file shared via link

[juliusknorr]

/backport to stable16

[blizzz]

That's a good catch already. Another use case are internal shares with placeholders in the config. They also don't resolve because of the wrong replacement it seems.

[scanom]

Just tested the PR and it solves partially the issues referenced. Shared files with path containing $user variable work fine now, but opening them with onlyoffice still broken (download failed). As before, same file without $user in path opens fine.

[juliusknorr]

That's a good catch already. Another use case are internal shares with placeholders in the config. They also don't resolve because of the wrong replacement it seems.

Hm, then I think it would be better if we pass though the user id that is used to setup the storage (as it seems that it was in stable15 and before). I'll have another look.

[juliusknorr]

@blizzz I've pushed another commit so we reuse the user id that is used to setup the mountpoints from

server/lib/private/Files/Filesystem.php

Line 395 in 1b85ef4

publicstaticfunctioninitMountPoints($user = '') {

@scanom I don't have a only office test setup, so maybe you can give that another try. At least for collabora this works just fine now.

[blizzz]

@juliushaertl let me test it today

[juliusknorr]

TypeError: Argument 1 passed to OCA\Files_External\Config\UserContext::__construct() must implement interface OCP\IUserSession, instance of Mock_IRequest_d7497604 given, called in /drone/src/apps/files_external/tests/Config/UserPlaceholderHandlerTest.php on line 59

Seems the tests also need another look 🤔 Not sure why they don't run yet.

[scanom]

@juliushaertl PR working flawlessly now, checked both Onlyoffice and Collabora.

[blizzz]

Issue persists for me, but it seems the issue is deeper. The wrong storage is used when looking for the file id. Still debugging.

[blizzz]

Issue persists for me, but it seems the issue is deeper. The wrong storage is used when looking for the file id. Still debugging.

There was an adjustment on the home handler needed, could have seen it way earlier. Stupid me.

[MorrisJobke]

Tested and works 👍

[MorrisJobke]

CI fails :/

[juliusknorr]

TypeError: Argument 1 passed to OCA\Files_External\Config\UserContext::__construct() must implement interface OCP\IUserSession, instance of Mock_IRequest_8a9960c5 given, called in /drone/src/apps/files_external/tests/Config/UserPlaceholderHandlerTest.php on line 59

Still not sure why that happens. Could it be that phpunit is not figuring out the proper type hints since it is in the constructor parent class (UserContext)?

[juliusknorr]

Tests should be fine now ... stupid typos.

[blizzz]

my commits got lost

and I think also something of yours, @juliushaertl, because I don't get the share owning user anymore. I don't recall what the change was here and I overwrote my local copy with this state :(

[juliusknorr]

Hm, not sure what happened, because I had your commits locally as I tested them. Github still has them, let try to grab them

[juliusknorr]

@blizzz Restored

[backportbot-nextcloud]

backport to stable16 in #16637