Skip to content

delay sending event from app init to when they are needed - #16638

Merged
rullzer merged 1 commit into
masterfrom
fix/noid/ldap-ext-storage-handler-loading-cli
Aug 8, 2019
Merged

delay sending event from app init to when they are needed#16638
rullzer merged 1 commit into
masterfrom
fix/noid/ldap-ext-storage-handler-loading-cli

Conversation

@blizzz

@blizzzblizzz commented Aug 2, 2019

Copy link
Copy Markdown
Member

Found while working on #16525, this is how to reproduce:

  1. Have LDAP enabled and an attributre entered for the "$home" variable for the external storage
  2. Have an external storage configured using it
  3. Run occ files:scan for an affected user

Output Before:

…
Folder /62A5ABEE-0360-47BE-BD40-1E5E387686BA/files_trashbin/files/Ogogogog.d1563983159
Folder /62A5ABEE-0360-47BE-BD40-1E5E387686BA/files/Common Files (Samba4)/
…

Output now (see the personal files showing up):

…
Folder /62A5ABEE-0360-47BE-BD40-1E5E387686BA/files_trashbin/files/Ogogogog.d1563983159
Folder /62A5ABEE-0360-47BE-BD40-1E5E387686BA/files/Personal Files (Samba4)/
File /62A5ABEE-0360-47BE-BD40-1E5E387686BA/files/Personal Files (Samba4)/Backtrace2.txt
Folder /62A5ABEE-0360-47BE-BD40-1E5E387686BA/files/Common Files (Samba4)/
…

No problem in the web interface.

@blizzz
delay sending event from app init to when they are needed
792903e
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzzblizzz added this to the Nextcloud 17 milestone Aug 2, 2019
@blizzz

blizzz commented Aug 2, 2019

Copy link
Copy Markdown
MemberAuthor

/backport to stable16

@blizzz

blizzz commented Aug 2, 2019

Copy link
Copy Markdown
MemberAuthor

/backport to stable15

rullzer
rullzer approved these changes Aug 2, 2019
View reviewed changes

@rullzerrullzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no tests :S...
anyways I'd like @icewind1991 take on it then I'm fine

@MorrisJobkeMorrisJobke mentioned this pull request Aug 8, 2019
Merged
28 tasks
icewind1991
icewind1991 approved these changes Aug 8, 2019
View reviewed changes

@icewind1991icewind1991 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fine

@rullzer
rullzer merged commit 10e2edc into masterAug 8, 2019
@rullzer
rullzer deleted the fix/noid/ldap-ext-storage-handler-loading-cli branch August 8, 2019 08:49
@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Aug 8, 2019
Merged
@backportbot-nextcloud

backportbot-nextcloudBot commented Aug 8, 2019

Copy link
Copy Markdown

backport to stable16 in #16695

@backportbot-nextcloud

backportbot-nextcloudBot commented Aug 8, 2019

Copy link
Copy Markdown

The backport to stable15 failed. Please do this backport manually.

@blizzz

blizzz commented Aug 9, 2019

Copy link
Copy Markdown
MemberAuthor

The backport to stable15 failed. Please do this backport manually.

scanning with a sharepoint mount works from occ, and the config mount backends were not introduced to 15 → Skipping

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzerrullzerrullzer approved these changes
@icewind1991icewind1991icewind1991 approved these changes
@juliusknorrjuliusknorrAwaiting requested review from juliusknorr
@kesselbkesselbAwaiting requested review from kesselb

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewsbugfeature: external storage

Projects

None yet

Milestone

Nextcloud 17

Development

Successfully merging this pull request may close these issues.

3 participants

@blizzz@rullzer@icewind1991