Uh oh!
There was an error while loading. Please reload this page.
[stable10] Improve user list rendering perf by not resorting after every add (#2… - #1694
Merged
Conversation
…6282) The call to UserList.add() was wrong and was passing "user.lastLogin" as the sort argument which would cause the list to be resorted over and over again for every added item after loading the next page of users.
mention-bot
commented
Oct 11, 2016
@MorrisJobke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @PVince81, @ringmaster and @blizzz to be potential reviewers. |
blizzz
approved these changes
Oct 11, 2016
blizzz
commented
Oct 11, 2016
Member
LGTM |
1 similar comment
rullzer
commented
Oct 11, 2016
Member
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…6282)
The call to UserList.add() was wrong and was passing "user.lastLogin"
as the sort argument which would cause the list to be resorted over and
over again for every added item after loading the next page of users.
Backport of #1679
I tested this with LDAP and it works.
cc @blizzz@nickvergessen@rullzer