Skip to content

re-acquired expired shared locks on large file uploads - #17926

Merged
rullzer merged 1 commit into
masterfrom
dav-upload-shared-lock-expired
Nov 14, 2019
Merged

re-acquired expired shared locks on large file uploads#17926
rullzer merged 1 commit into
masterfrom
dav-upload-shared-lock-expired

Conversation

@icewind1991

Copy link
Copy Markdown
Member

during large file uploads, the shared lock that we get at the begining can expire
leading to locked errors later on, instead of erroring, try to re-get the lock

Signed-off-by: Robin Appelman robin@icewind.nl

during large file uploads, the shared lock that we get at the begining can expire
leading to locked errors later on, instead of erroring, try to re-get the lock
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991icewind1991 added the 3. to review Waiting for reviews label Nov 13, 2019
@icewind1991icewind1991 added this to the Nextcloud 18 milestone Nov 13, 2019
@kesselb

Copy link
Copy Markdown
Contributor

Cool 👍 This will probably fix #9001

@ChristophWurstChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code makes sense

@rullzer
rullzer merged commit 224073e into masterNov 14, 2019
@rullzer
rullzer deleted the dav-upload-shared-lock-expired branch November 14, 2019 09:00
@icewind1991

Copy link
Copy Markdown
MemberAuthor

/backport to stable17

@icewind1991

Copy link
Copy Markdown
MemberAuthor

/backport to stable16

@backportbot-nextcloud

Copy link
Copy Markdown

backport to stable16 in #17944

@backportbot-nextcloud

Copy link
Copy Markdown

backport to stable17 in #17945

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@icewind1991@kesselb@ChristophWurst@skjnldsv@rullzer