Skip to content

Add typed create user events - #18028

Merged
rullzer merged 1 commit into
masterfrom
enhancement/user-create-events
Dec 3, 2019
Merged

Add typed create user events#18028
rullzer merged 1 commit into
masterfrom
enhancement/user-create-events

Conversation

@ChristophWurst

Copy link
Copy Markdown
Member

Discovered while working on nextcloud/mail#2259.

@ChristophWurstChristophWurst added the 3. to review Waiting for reviews label Nov 20, 2019
@ChristophWurstChristophWurst added this to the Nextcloud 18 milestone Nov 20, 2019
@ChristophWurstChristophWurst self-assigned this Nov 20, 2019

@rullzerrullzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it. very elegant

@juliusknorr
juliusknorrforce-pushed the enhancement/user-create-events branch from af88adb to 6292c00CompareNovember 21, 2019 18:22
@juliusknorr

This comment has been minimized.

@rullzer

This comment has been minimized.

@ChristophWurst
ChristophWurstforce-pushed the enhancement/user-create-events branch from 6292c00 to 04b098bCompareNovember 22, 2019 08:26
@rullzer
rullzerforce-pushed the enhancement/user-create-events branch 2 times, most recently from ad6bf0e to 12d6d87CompareNovember 26, 2019 13:40
@rullzer

Copy link
Copy Markdown
Member

Tests do 💥

@rullzer
rullzerforce-pushed the enhancement/user-create-events branch 2 times, most recently from 2a0fe9e to 7ebc026CompareNovember 29, 2019 08:14
@ChristophWurst
ChristophWurstforce-pushed the enhancement/user-create-events branch from 7ebc026 to f5d3fc2CompareDecember 2, 2019 08:04
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer
rullzerforce-pushed the enhancement/user-create-events branch from f5d3fc2 to cc80339CompareDecember 3, 2019 07:04
@rullzer
rullzer merged commit 1d707cc into masterDec 3, 2019
@rullzer
rullzer deleted the enhancement/user-create-events branch December 3, 2019 07:57
@MorrisJobke

Copy link
Copy Markdown
Member

ref #14552

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@ChristophWurst@juliusknorr@rullzer@MorrisJobke