Skip to content

Do not emit UserCreatedEvent twice - #23887

Merged
MorrisJobke merged 2 commits into
nextcloud:masterfrom
7118path:fix_23797
Nov 5, 2020
Merged

Do not emit UserCreatedEvent twice#23887
MorrisJobke merged 2 commits into
nextcloud:masterfrom
7118path:fix_23797

Conversation

@7118path

@7118path7118path commented Nov 4, 2020•
edited by ChristophWurst
Loading

Copy link
Copy Markdown
Contributor

no more translation from postCreateUser hook to UserCreatedEvent anymore, as event is already emitted in user manager

Fixes#23797

@ChristophWurstChristophWurst added 3. to review Waiting for reviews bug labels Nov 4, 2020
@ChristophWurstChristophWurst added this to the Nextcloud 21 milestone Nov 4, 2020
@ChristophWurstChristophWurst changed the title fix: no more translation from postCrerateUser hook to UserCreatedEventDo not emit UserCreatedEvent twiceNov 4, 2020
@ChristophWurst

ChristophWurst commented Nov 4, 2020

Copy link
Copy Markdown
Member

DCO check failed: https://github.com/nextcloud/server/pull/23887/checks?check_run_id=1351716573

Please sign off your commit :)

Tobias Assmann
fix: no more translation from postCreateUser hook to UserCreatedEvent…
ded2acc
… anymore, as event is already emitted in user manager
Signed-off-by: Tobias Assmann <tobias.assmann@ecsec.de>
@MorrisJobke

MorrisJobke commented Nov 4, 2020

Copy link
Copy Markdown
Member

@ecsecta Mind to also remove the use statement for this at the top of the file (that's the complaining code style about).

@MorrisJobkeMorrisJobke mentioned this pull request Nov 4, 2020
Merged
1 task
@7118path

7118path commented Nov 5, 2020

Copy link
Copy Markdown
ContributorAuthor

Yup, sorry.

Tobias Assmann
fix: also remove use statement of UserCreatedEvent
a79d7c0
Signed-off-by: Tobias Assmann <tobias.assmann@ecsec.de>
@MorrisJobke

MorrisJobke commented Nov 5, 2020

Copy link
Copy Markdown
Member

Yup, sorry.

Don't worry - that's what we have the CI jobs for. Reminding us of the easy to forget stuff.

@MorrisJobke

MorrisJobke commented Nov 5, 2020

Copy link
Copy Markdown
Member

Static code analysis fail is unrelated. That is from a wrong merge from yesterday.

@MorrisJobkeMorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 5, 2020
@MorrisJobke
MorrisJobke merged commit 0247f22 into nextcloud:masterNov 5, 2020
@welcome

welcomeBot commented Nov 5, 2020

Copy link
Copy Markdown

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@MorrisJobke

MorrisJobke commented Nov 5, 2020

Copy link
Copy Markdown
Member

/backport to stable20

@backportbot-nextcloud

backportbot-nextcloudBot commented Nov 5, 2020

Copy link
Copy Markdown

The backport to stable20 failed. Please do this backport manually.

@MorrisJobke

MorrisJobke commented Nov 5, 2020

Copy link
Copy Markdown
Member

Was added in #18028 and #18348. Also the emit does only happen in this one place so there is no need to translate it (for another app for example) anymore.

@MorrisJobkeMorrisJobke mentioned this pull request Nov 5, 2020
Merged
@MorrisJobke

MorrisJobke commented Nov 5, 2020

Copy link
Copy Markdown
Member

Backport in #23917

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobkeMorrisJobkeMorrisJobke approved these changes
@ChristophWurstChristophWurstChristophWurst approved these changes
@kesselbkesselbkesselb approved these changes
@rullzerrullzerAwaiting requested review from rullzer

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finishbug

Projects

None yet

Milestone

Nextcloud 21

Development

Successfully merging this pull request may close these issues.

UserCreatedEvent emitted twice when creating user via user management webui

4 participants

@7118path@ChristophWurst@MorrisJobke@kesselb