Add a PSR-3 logger adapter and make it injectable

[ChristophWurst]

Stumbled over https://www.php-fig.org/psr/psr-3/ because I'm writing a php library that I would like to make Nextcloud-agnostic. To be able to use a logger in the library, I chose to use the PSR-3 standard and inject a tiny adapter.

I figured it would make sense to have this in our code base. This smoothens the integration of 3rd party libraries.

Adding the interface as base of our ILogger is not possible as we have string type hints on the messages, whereas the PSR3 interface only has documented types.

[danopz]

PHP-FIG is currently working on adding types to existing PSRs

php-fig/fig-standards#1195
https://www.php-fig.org/blog/2019/10/upgrading-psr-interfaces/

Don't know if there is any plan when it will be there, just wanted to mention that

[ChristophWurst]

PHP-FIG is currently working on adding types to existing PSRs

Thanks a lot for this info. I wasn't aware of that. Then let's wait a bit until this has settled.

[ChristophWurst]

Still no 2.0 🤷‍♂️

[rullzer]

Still no 2.0 man_shrugging

do we want to wait?
Or just continue and thighten it later?

[ChristophWurst]

We can have types in the implementation already (thanks to php7.2)

Errrrr actually we can't. You can have a broader (super) type as hint, but you can't put string on a method parameter when the interface has no type.

[nickvergessen]

Yeah, I was about to say that. our logger is supposed to be compatible. So I'd say we either remove the type hints for now, or we wait until PSR added them?

[ChristophWurst]

Still no 2.0, so this won't be typed right now. But we can tighten later as you said.

Let's do this :)

[nickvergessen]

Fine by me and seems to be additional on top?
Should we ask people to use that instead?

[ChristophWurst]

Fine by me and seems to be additional on top?

Yes, right now our logging stays untouched.

Should we ask people to use that instead?

Let's maybe wait a bit for the typed interface. I hope this lands soon-ish. Then we can advertise the PSR logger more.