Uh oh!
There was an error while loading. Please reload this page.
Migrate custom loggers to PSR - #25588
Merged
Merged
Conversation
This will help phase out the deprecated ILogger interface. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
requested review from
blizzz, gary-kim, juliusknorr, pawohl and rullzerFebruary 11, 2021 15:17
rullzer
approved these changes
Feb 11, 2021
nickvergessen
approved these changes
Mar 5, 2021
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will help phase out the deprecated ILogger interface.
This is a follow-up to my old PR #18200.
Once we have a real logger that directly implements the PSR interface we can work without an adapter. But right now this is fine and the API change is more important than clean internals, because internals we can change any time.