Uh oh!
There was an error while loading. Please reload this page.
Add typed events for all user hooks and legacy events - #18225
Add typed events for all user hooks and legacy events#18225ChristophWurst wants to merge 2 commits into
Conversation
Uh oh!
There was an error while loading. Please reload this page.
rullzer
left a comment
There was a problem hiding this comment.
quick 🚬-test
looking good. Lets do this 🚀
db3bef7 to
5891d4eCompareChristophWurst
commented
Dec 9, 2019
rebased to resolve conflicts |
ChristophWurst
commented
Dec 10, 2019
updated to fix tests |
5891d4e to
df95437CompareMichaIng
commented
Dec 10, 2019
This solves #18331, right? |
ChristophWurst
commented
Dec 10, 2019
Nope. The uses of the old event are still a problem in some cases. I'll try to have a look at that as well. The problem is that we can't migrate those without introducing a breaking change 😢 |
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
df95437 to
6dfb31aCompareMichaIng
commented
Dec 10, 2019
@ChristophWurst |
ChristophWurst
commented
Dec 10, 2019
Those logs are fine. You only see them with log minimum log levels set. We want them to be visible for app developers so they take action timely. On production instances these lines won't show up. |
MichaIng
commented
Dec 10, 2019
@ChristophWurst |
ChristophWurst
commented
Dec 10, 2019
It's not just about the apps. As long as we emit the legacy event for BC reasons this info log will be shown. |
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
commented
Dec 11, 2019
Can't make CI happy here. #18348 is a simplified version for 18. Cleanup has to follow later. |
@ChristophWurst Can we close this now? |
Update
see #18348
-> existing code should continue to work, but new code can use the typed events with 18+
Note: I don't get the diff between
SessionandUserManagerhooks as we always emitted on the manager.