Skip to content

Add typed events for all group hooks and legacy events - #18322

Closed
ChristophWurst wants to merge 2 commits into
masterfrom
enhancement/typed-group-events
Closed

Add typed events for all group hooks and legacy events#18322
ChristophWurst wants to merge 2 commits into
masterfrom
enhancement/typed-group-events

Conversation

@ChristophWurst

@ChristophWurstChristophWurst commented Dec 10, 2019•
edited
Loading

Copy link
Copy Markdown
Member

Continuation of #18225

  • Add typed events
  • Emit events where we emitted legacy events and/or hooks
  • Catch new events and re-emit data as legacy events and/or hooks
  • preAddUser (\OC\Group\Group $group, \OC\User\User $user)
  • postAddUser (\OC\Group\Group $group, \OC\User\User $user)
  • preRemoveUser (\OC\Group\Group $group, \OC\User\User $user)
  • postRemoveUser (\OC\Group\Group $group, \OC\User\User $user)
  • preDelete (\OC\Group\Group $group)
  • postDelete (\OC\Group\Group $group)
  • preCreate (string $groupId)
  • postCreate (\OC\Group\Group $group)

-> existing code should continue to work, but new code can use the typed events with 18+

@ChristophWurst
Add typed events for all group hooks and legacy events
5bf119b
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurstChristophWurst added this to the Nextcloud 18 milestone Dec 10, 2019
@ChristophWurstChristophWurst self-assigned this Dec 10, 2019
@ChristophWurst
fixup! Add typed events for all group hooks and legacy events
b52a8d5
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@rullzerrullzer mentioned this pull request Dec 11, 2019
Merged
43 tasks
@ChristophWurstChristophWurst mentioned this pull request Dec 11, 2019
Merged
@ChristophWurstChristophWurst added 0. Needs triage Pending check for reproducibility or if it fits our roadmap and removed 2. developing Work in progress labels Dec 11, 2019
@ChristophWurstChristophWurst removed this from the Nextcloud 18 milestone Dec 11, 2019
@ChristophWurstChristophWurst mentioned this pull request Dec 11, 2019
Merged
@ChristophWurst

ChristophWurst commented Mar 6, 2020

Copy link
Copy Markdown
MemberAuthor

Integrated as #18350. The clean up has to be done on a french branch, I guess

@ChristophWurst
ChristophWurst deleted the enhancement/typed-group-events branch March 6, 2020 14:41
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@ChristophWurstChristophWurst

Labels

0. Needs triagePending check for reproducibility or if it fits our roadmapenhancementfeature: users and groupstechnical debt🧱 🤔🚀

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ChristophWurst