Allow to edit admin/own user in the user management

[juliusknorr]

• Fix own user editing (FixesEditing my user via user managment not possible #18530, FixesCurrent user cannot edit groups (18RC2) #18964, FixesNC18 - can not change own passwd / group  #19004, FixesCan not change admin settings #19072)
• Fix height of user rows
• Fix missing submit button in the display name field
• Fix group navigation (regression from Migrate to @nextcloud/vue 1.x.x #18917) No backport needed for this

[gary-kim]

1. Login as admin
2. Go to user management
3. Enter editing mode for yourself
4. Try to leave it (seems to work for any other user)

It seems that you currently cannot save when editing your own user.

server/apps/settings/src/components/UserList/UserRow.vue

Lines 211 to 218 in 32d279d

	<divclass="userActions">
	<divv-if="OC.currentUser !== user.id && user.id !== 'admin' && !loading.all"
	class="toggleUserActions">
	<Actions>
	<ActionButton icon="icon-checkmark"
	@click="editing=false">
	{{ t('settings', 'Done') }}
	</ActionButton>

[rullzer]

Ping :)

[rullzer]

master is NC19 now.
Please backport if it needs to go into 18

[kesselb]

Conflicts 😨

[wiswedel]

🏓

[wiswedel]

Anyone still alive fixing this?

[juliusknorr]

Yes, I was waiting for #19533 to be merged before doing another rebase dance.

[wiswedel]

Yes, I was waiting for #19533 to be merged before doing another rebase dance.

#19533 has been merged to master, but 18 backport failed

[juliusknorr]

All comments should be addressed, editing the own user is now limited to admin users as it is done in the backend.

Ready for review.

[kesselb]

As group admin add a new user without selecting a group. The warning is shown for the button not the group list. Also not a blocker.

[juliusknorr]

If Alice is a subdomain for group Test1234 and access the user list I see other users but not myself. I would expect to at least see Alice even if editing is disable. But not a blocker for this one. It's just confusing.

That actually works for me: user1 is group admin of group1

[kesselb]

Also anything related to showing quota seems to be broken. It seems to be possible to change the quota but not what quota is currently selected. But that's probably fixed by #18818.

[juliusknorr]

Also anything related to showing quota seems to be broken. It seems to be possible to change the quota but not what quota is currently selected. But that's probably fixed by #18818.

Oh joy, but yes, let's try to address that in #18818 then.

Same for the others. I can look into those, maybe you could create an issue for them, so I have a list rather than picking up pr comments.

[kesselb]

That actually works for me: user1 is group admin of group1

Ah. I made Alice group admin but not member of the group. But yes a different story because Alice is missing in the user response.

[gary-kim]

Tested and looked at the code. LGTM.

P.S. Never seen a computed returning a function before. Interesting.

[juliusknorr]

P.S. Never seen a computed returning a function before. Interesting.

Yeah the benefit of that is that the result is still cached, so it will only update if the dependency changes in contrast to a method.

[nursoda]

I seem to be missing something here: I just installed 18.0.3 and still I can't edit my own user (no pencil icon). I need that e.g. to be able to assign myself to new groups. Currently, my (clumsy) workaround is to impersonate another admin and modify my user there…

Apart from the huge vertical space for each user … I HAD an entry with MANY test groups since these were shown within other user lines in 18.0.0. Is it possible that the height is still calculated from the biggest (now deleted) entry?

[wiswedel]

I seem to be missing something here: I just installed 18.0.3 and still I can't edit my own user (no pencil icon). I need that e.g. to be able to assign myself to new groups. Currently, my (clumsy) workaround is to impersonate another admin and modify my user there…

I confirm that.
But even the impersonation trick does not work for the first admin that's been configured at installation.

[rullzer]

yeah 18.0.3 is a release with just a security fix.
This will come with 18.0.4

[vincentstans]

@ rullzer
You like to say stuff like that

Can i fix it by downloading and replacing some files ?

Sorry, @Uwe-MrT. It's only gonna be in 18.0.3, unless you check out the source and compile the Vue stuff by yourself. Then you can have it today.

[kesselb]

@vincentstans what part of "18.0.3 is a release with just a security fix" did you not understand?

[Hydrog3n]

Hello,
This seems not working in 19.0.0Beta4 with only one user in my case.

[nursoda]

Works fine in 19 beta 5, thanks!