change quota design

[GretaD]

fixes#18540, #19969

[jancborchardt]

• The text should be left-aligned, as with the other entries
• If nothing is used, it can be "(0 used)", no unit needed
• Would still be nice to get the bar back, otherwise people need to read it all and calc in their head

Otherwise it looks good! :)

[kesselb]

Thanks @GretaD 👍

Index: apps/settings/src/components/UserList/UserRowSimple.vue
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
--- apps/settings/src/components/UserList/UserRowSimple.vue	(revision 8d84710e266bd821fec441b238f7801216c8d11a)
+++ apps/settings/src/components/UserList/UserRowSimple.vue	(date 1579182181172)
@@ -33,7 +33,12 @@
{{ userSubAdminsGroupsLabels }}
</div>
<div class="quota">
- {{ userQuota }} ({{ usedSpace }})
+ <span>{{ userQuota }} ({{ usedSpace }})</span>
+ <progress
+ class="quota-user-progress"
+ :class="{'warn': usedSpace > 80}"
+ :value="usedSpace"
+ max="100" />
</div>
<div v-if="showConfig.showLanguages" class="languages">
{{ userLanguage.name }}
@@ -169,4 +174,13 @@
text-overflow: ellipsis;
white-space: nowrap;
}
+	.quota span {
+ margin-left: 10px;
+	}
+	.quota progress {
+ position: absolute;
+ bottom: 0;
+	}
</style>

I guess there are cleaner ways to do it ;) Also some tweaks for smaller screens would be good.

done

[kesselb]

Needs a rebase.

[kesselb]

Looks like that on my machine. I run make all a few times but the result seems to be the same.

• The quota header column should be aligned with the other header columns (text left not centered)
• Also the quota text for a user is centered
• The overlapping with the edit button is probably fixed with a rebase

[kesselb]

😕

[GretaD]

confused

ouch, what happened there? /hides

[kesselb]

Looks good to me.

Would be nice to see the current quota also in edit mode. But not a blocker for this pr.

[juliusknorr]

The quota bar positioning still seems a bit off

[juliusknorr]

I would suggest to wrap both the text and process in a wrapping div so you can more easily style those without the need of a absolute positioning.

[kesselb]

cc @GretaD mind to rebase?

[tanderson8]

apps/settings/src/components/UserList/UserRowSimple.vue

I'm not seeing an /src directory from my /settings directory. Do I need to just add it and push the file to it for these changes to take effect?

[GretaD]

@tanderson8 is you master up to date? You normally should have the UserRowSimple.vue file when you checkout out at rethink_quota branch.

[juliusknorr]

Let's do this. The quota/language assignment issue will be fixed by nextcloud-libraries/nextcloud-vue#924

@GretaD Mind to rebase and commit the bundles?

[juliusknorr]

/backport to stable18

[backportbot-nextcloud]

The backport to stable18 failed. Please do this backport manually.

[kesselb]

This pull request reverts #18555 partly. It's again not possible to edit my own user account.

cc @GretaD@juliushaertl

[juliusknorr]

@GretaD It seems this was reverted for some reason as @kesselb mentioned as well as the related part in the template. I did not notice that during review, so it was probably during rebase? Could you look into fixing that again?

[GretaD]

yes sure