Uh oh!
There was an error while loading. Please reload this page.
Added functions to check etag of elements - integration tests - #1887
Conversation
mention-bot
commented
Oct 24, 2016
@MorrisJobke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @SergioBertolinSG, @rullzer and @PVince81 to be potential reviewers. |
rullzer
commented
Oct 24, 2016
Mmmm the test fails. |
b9b7a62 to
9933803Compare| } | ||
| if (!$this->canAccessShare($share, false)) { | ||
| if (!$this->canAccessShare($share, true)) { |
There was a problem hiding this comment.
Well true is the default. Also the parameter was specifically introduced for this case: #637
There was a problem hiding this comment.
Yeah I remember that. It is just that apparently a lot of tests still reply on you to be able to delete received shares via the API.
Regarding the last commit, shouldn't you delete the "share exception" instead of the group share, to unshare from self?
|
rullzer
commented
Oct 25, 2016
@nickvergessen ah yes could do that. lets first see if this fixes it then I'll try to make it a bit more beautiful :D |
de9e20d to
a8782c4CompareSigned-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
a8782c4 to
ea786a3Comparerullzer
commented
Nov 2, 2016
@nickvergessen could you smash? Then this is ready to get in |
nickvergessen
commented
Nov 2, 2016
Smashing passed. 👍 |
MorrisJobke
commented
Nov 2, 2016
👍from me as well |
cc @rullzer@nickvergessen