Uh oh!
There was an error while loading. Please reload this page.
Do not allow to delete/update group shares as a group member - #637
Merged
Conversation
mention-bot
commented
Jul 28, 2016
@nickvergessen, thanks for your PR! By analyzing the annotation information on this pull request, we identified @rullzer, @PVince81 and @DeepDiver1975 to be potential reviewers |
rullzer
commented
Jul 28, 2016
Member
O man that is nasty indeed. |
schiessle
commented
Jul 29, 2016
Member
setting to "developing" until tests are added |
rullzerforce-pushed
the
h1-prevent-delete-update-on-group-shares
branch
from
August 2, 2016 09:01
4ef0a5c to
a6d6b26Comparerullzer
commented
Aug 2, 2016
Member
And we have an intergration test! @schiessle please review |
rullzer
commented
Aug 2, 2016
Member
👍 for @nickvergessen commit |
schiessle
commented
Aug 2, 2016
Member
looks good 👍 |
MemberAuthor
👍 |
rullzerforce-pushed
the
h1-prevent-delete-update-on-group-shares
branch
from
August 2, 2016 09:12
a6d6b26 to
1088870Compare
This was referenced Aug 3, 2016
GitHubUser4234 pushed a commit
to GitHubUser4234/server
that referenced
this pull request
Aug 30, 2016
…ate-on-group-shares Do not allow to delete/update group shares as a group member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@rullzer can you please take care of adding tests?